Skip to content

Add timestamps to Message#436

Open
rock-n-shrimproll wants to merge 13 commits intodevfrom
feat/add_timestamps
Open

Add timestamps to Message#436
rock-n-shrimproll wants to merge 13 commits intodevfrom
feat/add_timestamps

Conversation

@rock-n-shrimproll
Copy link
Collaborator

@rock-n-shrimproll rock-n-shrimproll commented Apr 30, 2025

Description

Please describe here what changes are made and why.

Checklist

  • I have performed a self-review of the changes
  • Add docstring for fields in Message class

List here tasks to complete in order to mark this PR as ready for review.

To Consider

  • Add tests (if functionality is changed)
  • Update API reference / tutorials / guides
  • Update CONTRIBUTING.md (if devel workflow is changed)
  • Update .ignore files, scripts (such as lint), distribution manifest (if files are added/deleted)
  • Search for references to changed entities in the codebase

@rock-n-shrimproll rock-n-shrimproll self-assigned this Apr 30, 2025
@rock-n-shrimproll rock-n-shrimproll marked this pull request as ready for review May 29, 2025 13:44
annotations: Optional[Dict[str, Any]] = None,
misc: Optional[Dict[str, Any]] = None,
origin: Optional[Origin] = None,
timestamp: Optional[int] = None,
Copy link
Member

@RLKRo RLKRo Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add documentation.

  • mention that this field is modified in BaseResponse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants