Draft
Conversation
RLKRo
reviewed
Jun 18, 2025
chatsky/core/ctx_utils.py
Outdated
| - no transition has been made during this turn yet (e.g. the turn is in the pre-transition step); | ||
| - no valid transition has been found (i.e. transitioned to fallback node). | ||
| """ | ||
| current_stage: Optional[Literal[*STAGES]] = Field(default=None, exclude=True) |
Member
There was a problem hiding this comment.
Can try to do Literal[*ExceptionInfo.model_fields.keys()] to avoid duplication in ExceptionInfo and STAGES.
RLKRo
reviewed
Jun 27, 2025
chatsky/core/ctx_utils.py
Outdated
| """ | ||
|
|
||
|
|
||
| STAGES = [ |
chatsky/core/ctx_utils.py
Outdated
| ] | ||
|
|
||
|
|
||
| class ExceptionInfo(BaseModel, arbitrary_types_allowed=True): |
Member
There was a problem hiding this comment.
Remove exception info model, replace with Dict[Stages, List[Exception]], and defaultdict(list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please describe here what changes are made and why.
Checklist
List here tasks to complete in order to mark this PR as ready for review.
To Consider
.ignorefiles, scripts (such aslint), distribution manifest (if files are added/deleted)