Add install script and script to run packgen.py#2
Open
wehimwich wants to merge 1 commit intodehorsley:masterfrom
Open
Add install script and script to run packgen.py#2wehimwich wants to merge 1 commit intodehorsley:masterfrom
wehimwich wants to merge 1 commit intodehorsley:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ended up taking a different direction than I originally intended for #1. There is now an install script and a script packgen that runs the original code, which is now in packgen.py. There may well be better ways to handle this.
Generally, I find that this approach is not as portable as I would hope. For this repo, it does work on my Mac (Sequoia) and Bullseye (FSL11). However for others, pip3 may fail to find older packages in requirements.txt. The result being that changes are needed to use newer versions.