31 register callback decorator#51
Open
JAuriac wants to merge 17 commits intodeisa-project:mainfrom
Open
Conversation
benoitmartin88
requested changes
Apr 23, 2026
Contributor
benoitmartin88
left a comment
benoitmartin88
left a comment
There was a problem hiding this comment.
I think this is a good start.
…nside main callback function
Contributor
|
Is this PR still a draft or is it ready for review ? |
benoitmartin88
requested changes
Apr 27, 2026
Contributor
benoitmartin88
left a comment
benoitmartin88
left a comment
There was a problem hiding this comment.
A few changes are needed.
Could you rebase on main to take into account the DeisaArray changes ?
benoitmartin88
requested changes
Apr 30, 2026
benoitmartin88
requested changes
May 4, 2026
…orator inputs always as tuples
…a tuple, remove window_size as keyword argument
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #31