Skip to content

42 ruff code format#52

Open
JAuriac wants to merge 2 commits intodeisa-project:mainfrom
JAuriac:42_RuffCodeFormat
Open

42 ruff code format#52
JAuriac wants to merge 2 commits intodeisa-project:mainfrom
JAuriac:42_RuffCodeFormat

Conversation

@JAuriac
Copy link
Copy Markdown
Collaborator

@JAuriac JAuriac commented Apr 23, 2026

Close #42

Use ruff check . && pytest, only needs pip install.
And via VS Code / Pycharm through the Ruff extension / external tool.

@JAuriac JAuriac changed the title Add minimal pyproject.toml for Ruff use 42 ruff code format Apr 23, 2026
@JAuriac JAuriac marked this pull request as ready for review April 27, 2026 08:19
Copy link
Copy Markdown
Contributor

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start. Question: should we use a dedicated ruff.toml or should the ruff config be in the pyproject.toml ?

@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented Apr 30, 2026

This is a good start. Question: should we use a dedicated ruff.toml or should the ruff config be in the pyproject.toml ?

From what i read, those two files can be merged without issues, which allows us to have the tools configuration together.

https://docs.bswen.com/blog/2026-03-29-ruff-config-file-choice/#:~:text=use%3F-,Choose,project
and
https://docs.astral.sh/ruff/configuration/#config-file-discovery:~:text=the%20ruff%2Etoml%20file%20will%20take%20precedence%20over%20the%20pyproject%2Etoml%20file

@benoitmartin88
Copy link
Copy Markdown
Contributor

My question was more of a exploratory one. What should we choose? What is the benefit of one over the other?

@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented May 4, 2026

My question was more of a exploratory one. What should we choose? What is the benefit of one over the other?

Not much, really, it is rather a question of preference, with whether we want a unified or split configuration

Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented May 6, 2026

Might need rebase

@JAuriac JAuriac force-pushed the 42_RuffCodeFormat branch from 900e711 to 59276a9 Compare May 7, 2026 07:25
@JAuriac JAuriac force-pushed the 42_RuffCodeFormat branch from 59276a9 to 73e8c3a Compare May 7, 2026 07:28
@JAuriac JAuriac requested a review from benoitmartin88 May 7, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use ruff for format code

2 participants