Skip to content

41 pyproject toml#53

Open
JAuriac wants to merge 5 commits intodeisa-project:mainfrom
JAuriac:41_PyprojectToml
Open

41 pyproject toml#53
JAuriac wants to merge 5 commits intodeisa-project:mainfrom
JAuriac:41_PyprojectToml

Conversation

@JAuriac
Copy link
Copy Markdown
Collaborator

@JAuriac JAuriac commented Apr 23, 2026

Close #41

@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented Apr 23, 2026

First draft using setuptools

@JAuriac JAuriac marked this pull request as ready for review April 27, 2026 08:19
Copy link
Copy Markdown
Contributor

@benoitmartin88 benoitmartin88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. I have a question: should we use setuptools or something a little more modern like uv ?

@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented Apr 30, 2026

This looks pretty good. I have a question: should we use setuptools or something a little more modern like uv ?

This version uses an older setuptools as a default to handle olders environments. We can use uv to handle the environment and keep the build with setuptools ? We may replace setuptools with hatchling or flit (example with hatchling in next commit)

@benoitmartin88
Copy link
Copy Markdown
Contributor

I don't need an example with hatchling.
I was just wondering what would be the advantages of using a modern build system. What do you think?

@JAuriac
Copy link
Copy Markdown
Collaborator Author

JAuriac commented May 4, 2026

I don't need an example with hatchling. I was just wondering what would be the advantages of using a modern build system. What do you think?

As Deisa is light enough, there wouldn't be much difference between the two. I rather see advantages in using setuptools, as building Deisa linked to PDI may eventually give issues (on specific OS for example) which can be easier to handle with setuptools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

replace setup.py by pyproject.toml

2 participants