This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Add support for pulling Spin OCI images#180
Merged
Mossaka merged 3 commits intodeislabs:mainfrom Nov 13, 2023
Merged
Conversation
jsturtevant
force-pushed
the
spin-oci
branch
from
58c4546 to
ffc18b6
Compare
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
spin-oci
branch
from
ffc18b6 to
cfdf625
Compare
jsturtevant
force-pushed
the
spin-oci
branch
from
130a969 to
daea6e8
Compare
radu-matei
approved these changes
Nov 13, 2023
Member
radu-matei
left a comment
radu-matei
left a comment
There was a problem hiding this comment.
Tested this in a new k3d cluster with a Spin app published to a registry using spin registry push and everything works great!
Thank you so much for the work here!
Member
|
This can be a follow-up task. Could you please add at least one integration test for testing spin OCI images? |
Mossaka
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #164