feat: make AdaptiveThrottle instances independently configurable#7
Merged
feat: make AdaptiveThrottle instances independently configurable#7
Conversation
Add three new AdaptiveThrottleOption constructors that let each instance override the behaviour previously only configurable via globals: WithRejectedErrorFunc — replaces global IsRejectedError WithClientSideRejectionError — replaces global ClientSideRejectionError WithNow — replaces global Now Each falls back to the corresponding global when not set, preserving full backward compatibility. The globals are now deprecated in favour of the per-instance options. The constructor also uses WithNow when seeding the initial windowed counters, so clock control is complete from the moment of construction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The global variables
IsRejectedError,ClientSideRejectionError, andNowmade it impossible to run multipleAdaptiveThrottleinstanceswith different behaviour, and caused tests to share clock and error
classification state.
This PR introduces per-instance equivalents via three new options:
WithRejectedErrorFunc(fn)IsRejectedErrorWithClientSideRejectionError(err)ClientSideRejectionErrorWithNow(fn)NowEach option falls back to the corresponding global when not set, so all
existing code continues to work without changes.
The globals are marked deprecated with a pointer to their per-instance
replacement. They will be removed in v2.
Backward compatibility
No breaking changes. Callers that mutate the globals directly continue
to work as before; the fallback path reads the global at call time.