-
Notifications
You must be signed in to change notification settings - Fork 3
New navigation menu, virtualization, about page, logo and other UI improvements #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new navigation system with sidebar context management, adds an about page, implements virtualization for better performance, and includes various UI improvements including a new logo.
- New sidebar context provider for global state management with element and open/closed state
- Virtualization implementation using @tanstack/react-virtual to handle large data sets efficiently
- Complete navigation refactoring from URL-based to context-based state management
Reviewed Changes
Copilot reviewed 34 out of 41 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Website/contexts/SidebarContext.tsx | New context provider for sidebar state management |
| Website/contexts/DatamodelViewContext.tsx | New context for datamodel view state and navigation |
| Website/components/datamodelview/List.tsx | Virtualized list implementation with scroll tracking |
| Website/components/datamodelview/DatamodelView.tsx | Main datamodel view component using new architecture |
| Website/components/aboutview/AboutView.tsx | New about page component |
| Website/components/AppSidebar.tsx | Refactored sidebar component using new context |
| Website/package.json | Updated dependencies and version, added prepipeline script |
Files not reviewed (1)
- Website/package-lock.json: Language not supported
Comments suppressed due to low confidence (4)
Website/components/datamodelview/SidebarDatamodelView.tsx:21
- [nitpick] Empty destructuring syntax '{ }' is unnecessary when the interface is empty. Consider using 'props: ISidebarDatamodelViewProps' or removing the parameter entirely.
export const SidebarDatamodelView = ({ }: ISidebarDatamodelViewProps) => {
Website/components/datamodelview/List.tsx:11
- [nitpick] Empty destructuring syntax '{ }' is unnecessary when the interface is empty. Consider using 'props: IListProps' or removing the parameter entirely.
export const List = ({ }: IListProps) => {
Website/components/aboutview/AboutView.tsx:10
- [nitpick] Empty destructuring syntax '{}' is unnecessary when the interface is empty. Consider using 'props: IAboutViewProps' or removing the parameter entirely.
export const AboutView = ({}: IAboutViewProps) => {
Website/components/AppSidebar.tsx:11
- [nitpick] Empty destructuring syntax '{}' is unnecessary when the interface is empty. Consider using 'props: IAppSidebarProps' or removing the parameter entirely.
export const AppSidebar = ({}: IAppSidebarProps) => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DMV Changes
This PR introduces a new navigation system and about page, along with various UI improvements and refactoring changes.
Also a new logo has been created. Feel free to leave feedback for the logo.
Screenshots and Gifs
New Virtualization
New Navigation on Phone
About page
Major Changes:
Minor Changes: