Minor changes #46
Merged
Minor changes #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses several UI/UX improvements and a security role generation bug fix. The changes focus on enhancing the mobile experience and adding optional logo support while fixing a potential issue in the security role generation process.
- Security role generation fix to handle empty role collections
- Implementation of optional logo display in the sidebar
- Mobile UI improvements with search box visibility management and z-index adjustments
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes semver dependency |
| Website/stubs/Data.ts | Adds Logo export with proper semicolon formatting |
| Website/components/datamodelview/TimeSlicedSearch.tsx | Adds mobile responsiveness, clear button functionality, and improved z-index handling |
| Website/components/AppSidebar.tsx | Implements optional logo display logic and fixes z-index layering issues |
| Generator/WebsiteBuilder.cs | Generates Logo configuration export with proper null handling |
| Generator/DataverseService.cs | Adds guard clause for empty security roles collection |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes