-
Notifications
You must be signed in to change notification settings - Fork 3
Patch: Search Changes #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… option and small indication for active globalsearch. Also small warning if both search options are being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the search functionality across data model components by adding support for searching within option values of choice/status attributes, converting the search worker to TypeScript for better type safety, and implementing various UI improvements including scroll position preservation and better search state management.
- Added comprehensive search support for ChoiceAttribute and StatusAttribute option values
- Converted searchWorker from JavaScript to TypeScript with proper type definitions
- Enhanced search UI with local search inputs, escape key handling, and dual search warnings
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| searchWorker.ts | New TypeScript version with type definitions and enhanced attribute option searching |
| searchWorker.js | Removed JavaScript version of the search worker |
| TimeSlicedSearch.tsx | Added minimum character requirements, escape key handling, and scroll preservation |
| Relationships.tsx | Added local search input with dual search warnings and escape key support |
| List.tsx | Enhanced search state handling and improved loading/empty states |
| Keys.tsx | Added local search functionality with dual search warnings |
| DatamodelView.tsx | Updated worker import to use TypeScript version |
| Attributes.tsx | Enhanced search to include option values and added local search UI |
| ChoiceAttribute.tsx | Added highlighting support for option values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Search Improvements:
Added support for searching option values in ChoiceAttribute and StatusAttribute fields
Fixed issue where attributes with matching option values were not displayed in search results
Added scroll position preservation when clearing search queries
Code Quality:
Converted searchworker to TypeScript with proper type definitions
Added comprehensive type safety for worker message interfaces
Bug Fixes:
Fixed attribute filtering logic to include option name matching
Improved search result accuracy for both global and local searches