TOOL-28331 kernel module builds fail in install_kernel_headers_and_dbgsyms #362
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we look at the most recent failed jobs to update the linux-kernel-generic package: https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/develop/job/update-package/job/linux-kernel-generic/234/
The merge itself is clean, but what's failing is the zfs and connstat package builds that are done as part of validating the kernel build. If we look at that connstat build as an example (https://ops-jenkins.eng-tools-prd.aws.delphixcloud.com/job/linux-pkg/job/develop/job/build-package/job/connstat/job/pre-push/362/console), we see it fails with:
The zfs build fails the same way.
The code that issues that
ln -s
call is theinstall_kernel_headers_and_dbgsyms()
function in linux-pkg's lib/common.sh file:The problem is that we’re building on AWS, and the VM that the build runs on has a pre-existing link created by appliance-build when that base image was created. The linux-pkg code should use ln -sf to overwrite that link.
Testing
ab-pre-push: https://selfservice-jenkins.eng-tools-prd.aws.delphixcloud.com/job/appliance-build-orchestrator-pre-push/11758/
The above was run from the linux-pkg repo as
git ab-pre-push -b connstat
to show a successfull connstat module build.