Open
Conversation
nicolas3355
commented
May 4, 2021
nicolas3355
commented
- Updated the code to python3.
- Made the code more readable my reflecting the Merkle-Damgard construction of sha256.
- Added more tests.
3atharvkurdukar
left a comment
3atharvkurdukar
left a comment
There was a problem hiding this comment.
@nicolas3355 Can you please explain why you converted the digest to hex for each block? The mutate function was anyhow taking digest as an input. So, what was the need of converting it to hex and back to digest?
Author
|
sorry about that, should be all good now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.