Skip to content

avoid negative fixed point value in calc_max_short #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

avoid negative fixed point value in calc_max_short #19

wants to merge 21 commits into from
+91 −37

Conversation

@wakamex
Copy link
Contributor

@wakamex wakamex commented May 1, 2024 •
edited
Loading

  • avoid negative fixed point value in calc_max_short by removing unnecessary brackets
  • widen factory settings to allow time stretch and fixed rates in the range of 0-1000% (from 1-50%)

@wakamex wakamex requested a review from slundqui as a code owner May 2, 2024 19:42
@wakamex wakamex marked this pull request as draft May 2, 2024 19:43
@wakamex wakamex added bug Something isn't working and removed bug Something isn't working labels May 2, 2024
This was referenced May 2, 2024
Closed
Closed
@wakamex wakamex force-pushed the separate_subtractions branch from 4ef681e to c874cc5 Compare June 1, 2024 05:39
@wakamex wakamex changed the title separate subtractions from share reserves to avoid negative value fuzz over wider range Jun 1, 2024
@wakamex wakamex force-pushed the separate_subtractions branch from c246b8a to 06a9c6d Compare June 1, 2024 15:12
@wakamex wakamex changed the title fuzz over wider range avoid negative fixed point value in calc_max_short Jun 3, 2024
@wakamex wakamex mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jalextowle jalextowle Awaiting requested review from jalextowle

@jrhea jrhea Awaiting requested review from jrhea

@mcclurejt mcclurejt Awaiting requested review from mcclurejt

@dpaiton dpaiton Awaiting requested review from dpaiton

@sentilesdal sentilesdal Awaiting requested review from sentilesdal

@ryangoree ryangoree Awaiting requested review from ryangoree

@slundqui slundqui Awaiting requested review from slundqui

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wakamex