Update repo-consistency agent and apply TemplateDotNetLibrary improvements#17
Draft
Update repo-consistency agent and apply TemplateDotNetLibrary improvements#17
Conversation
- Migrate linting configs from JSON to YAML format: - Rename .cspell.json -> .cspell.yaml with policy comments and improved ignorePaths - Rename .markdownlint-cli2.jsonc -> .markdownlint-cli2.yaml with full documentation - Update .yamllint.yaml with improved ignore paths and remove check-keys: true - Rewrite lint.sh and lint.bat to use npm install + Python venv pattern - Uses 'npx cspell --no-progress --no-color' with expanded file extensions - Sets up .venv/ for yamllint via pip-requirements.txt - Continues all checks even on failure (collects all errors) - Add pip-requirements.txt with yamllint==1.38.0 - Update package.json to include cspell 9.7.0 and markdownlint-cli2 0.21.0 - Add .venv/ to .gitignore - Update build.yaml quality-checks job: - Add Setup Node.js (actions/setup-node@v6) and Setup Python (actions/setup-python@v6) steps - Replace three separate linting Actions with single 'bash ./lint.sh' step - Create .gitattributes to enforce LF line endings (eol=crlf for .bat/.cmd) - Add tools: and user-invocable: true frontmatter to all 5 agent files - Update .github/pull_request_template.md to consolidate linting checklist - Update AGENTS.md: fix config file names, add spell check word list policy - Update CONTRIBUTING.md: update spell check policy and linting instructions - Bump BuildMark from 0.4.0 to 0.4.1 in .config/dotnet-tools.json
Copilot
AI
changed the title
[WIP] Update repo consistency agent from TemplateDotNetLibrary
Update repo-consistency agent and apply TemplateDotNetLibrary improvements
Mar 24, 2026
Malcolmnixon
requested changes
Mar 24, 2026
| if %errorlevel% neq 0 exit /b %errorlevel% | ||
| REM Run yamllint check | ||
| yamllint . | ||
| if errorlevel 1 set "LINT_ERROR=1" |
Contributor
There was a problem hiding this comment.
Consider keeping the dotnet format --verify-no-change check after the yamllint check, but using the same LINT_ERROR propagation approach as the other checks.
Contributor
Author
There was a problem hiding this comment.
Added dotnet format --verify-no-changes after the yamllint check with the same LINT_ERROR propagation pattern in f2b0b1a.
|
|
||
| # Run yamllint check | ||
| yamllint . || lint_error=1 | ||
|
|
Contributor
There was a problem hiding this comment.
Consider keeping the dotnet format --verify-no-changes but put it after the yamllint and keep the lint_error propagation approach shown for the other checks.
Contributor
Author
There was a problem hiding this comment.
Added dotnet format --verify-no-changes after the yamllint check with the same lint_error propagation pattern in f2b0b1a.
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com> Agent-Logs-Url: https://github.com/demaconsulting/NuGetCaching/sessions/e96c680b-50bc-4fba-8140-ecefca3518ca
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in the latest
repo-consistencyagent from TemplateDotNetLibrary and runs it to propagate outstanding template improvements (PRs #43–#64).Description
Agent update: Replaces the verbose old
repo-consistency-agent.mdwith the new concise frontmatter-driven format (name,description,tools,user-invocable).Linting infrastructure overhaul:
.cspell.yaml,.markdownlint-cli2.yaml.yamllint.yamlwith DO NOT MODIFY headers and expanded ignore pathslint.sh/lint.batto usenpm install+ Python.venvpattern; collects all errors before failing; addeddotnet format --verify-no-changesafter yamllint checkpip-requirements.txt(yamllint==1.38.0) and pinnedcspell/markdownlint-cli2inpackage.json.venv/to.gitignoreCI workflow: Replaced three separate linting Actions with a single
bash ./lint.shstep backed byactions/setup-node@v6andactions/setup-python@v6.Agent frontmatter: Added
tools:anduser-invocable: trueto all five agent files.Git/repo hygiene:
.gitattributesenforcing LF for all text files, CRLF for.bat/.cmd0.4.0→0.4.1Docs: Updated
AGENTS.md,CONTRIBUTING.md, and.github/pull_request_template.mdto reflect new config file names, spell-check policy ("never silence failures by adding misspelled words"), and consolidated linting checklist.Type of Change
Pre-Submission Checklist
Build and Test
dotnet build --configuration Releasedotnet test --configuration ReleaseCode Quality
dotnet format --verify-no-changesQuality Checks
./lint.sh(Unix/macOS) orcmd /c lint.bat/./lint.bat(Windows)Testing
Documentation
Additional Notes
All linters pass post-migration: cspell (31 files, 0 issues), markdownlint-cli2 (18 files, 0 errors), yamllint (0 errors), dotnet format (0 issues).
⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.