Update to latest repo-consistency agent and improvements from template#131
Update to latest repo-consistency agent and improvements from template#131
Conversation
|
@copilot Please retry |
- Add .gitattributes to enforce LF line endings (PR #71) - Rename agent files to .agent.md naming convention (PR #61/#65) - Add tools: and user-invocable: true to all agent frontmatter (PR #73) - Use kebab-case name: fields in agent frontmatter - Replace .cspell.json with .cspell.yaml (YAML format with policy comments) (PR #61/#63) - Replace .markdownlint-cli2.jsonc with .markdownlint-cli2.yaml (PR #61) - Update .yamllint.yaml ignore patterns with thirdparty dirs (PR #64) - Update lint ignore paths with better glob patterns (PR #64) - Add spell check word list policy to AGENTS.md (PR #63) - Add Spell Checking section to CONTRIBUTING.md (PR #63) - Update Defer To sections to Subagent Delegation pattern (PR #65) - Fix linting config file name references in agent files
…engths - Update .agent.md extension references in AGENTS.md and technical-writer.agent.md - Remove 'Propagatable' from .cspell.yaml (not used in ReqStream) - Fix MD013 line length violations in AGENTS.md and technical-writer.agent.md
Done. Applied the latest repo-consistency agent from TemplateDotNetTool and then used it to apply the remaining template improvements (commits f2d6636, 68bc071, d2f9552):
All linting checks pass (markdownlint: 0 errors, cspell: 0 issues, yamllint: 0 errors). |
|
@copilot I think you missed many changes - I'm not seeing the .reviewmark.yaml in here which indicates numerous PRs were missed. |
Apply all missing changes from the TemplateDotNetTool template to bring ReqStream into consistency with the latest template patterns. Changes applied from PRs #58-#74: PR #58 (ReviewMark integration): - Add .reviewmark.yaml with ReqStream-specific review sets - Add pip-requirements.txt (yamllint==1.38.0) - Update lint.sh/lint.bat to use Python venv + pip pattern - Update package.json with pinned cspell and markdownlint-cli2 devDependencies - Add demaconsulting.reviewmark to .config/dotnet-tools.json - Add reviewmark entry to .versionmark.yaml PR #59 (Add Code Review Agent to AGENTS.md invocation rules): - Add code-review agent to AGENTS.md available agents list - Add new .github/agents/code-review.agent.md PR #61 (Linting modernization and agent file standardization): - Update .markdownlint-cli2.yaml with PURPOSE/DO NOT MODIFY header - Update .yamllint.yaml with PURPOSE/DO NOT MODIFY header - Remove check-keys from yamllint truthy rule (aligns with template) PR #63 (enforce cspell word list policy): - Update .cspell.yaml header comment (NEVER add misspelled word) - Add missing technical terms to cspell word list (reviewmark, ReviewMark, versionmark, VersionMark, buildmark, BuildMark, gitattributes, etc.) PR #64 (Align lint YAML configs): - Apply standardized headers to markdownlint and yamllint configs PR #65-#67, #70-#73 (Agent synchronization): - Update code-quality.agent.md to template version (comprehensive content) - Update agent frontmatter descriptions to match shorter template pattern - Update repo-consistency agent and requirements, software-developer, technical-writer, test-developer agents PR #71 (.gitattributes LF line endings): - .gitattributes already had correct content PR #72 (Simplify repo-consistency agent): - repo-consistency.agent.md already aligned PR #54 (Various improvements): - Update .versionmark.yaml regex patterns to support pre-release versions - Update .gitignore to match template structure CONTRIBUTING.md: - Rewrite to match template standards with ReqStream-specific translation - Add dotnet tool restore step, XML documentation section - Add comprehensive testing guidelines with MSTest v4 assertions - Add requirements management section
Re-ran the repo-consistency agent following its explicit instructions (fetching the 20 most recently merged PRs and applying all missing changes). Commit 48d74ac applies the remaining changes including:
All linting passes (cspell: 0 issues, markdownlint: 0 errors, yamllint: 0 errors). Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Brings in the latest repo-consistency agent from the TemplateDotNetTool repo and applies all template improvements to ReqStream identified by running the agent against the 20 most recently merged PRs.
Pull Request
Description
Updates the repo-consistency agent to the latest version from TemplateDotNetTool and applies all missing template improvements identified by running the agent.
Changes made:
repo-consistency-agent.mdwith the newrepo-consistency.agent.mdformat (shorter, more focused, with YAML frontmatter).agent.mdnaming convention (PR [Feature]: Fix SonarQube Duplicate Code Issue #61/[Feature]: SonarQube cleanup #65 from template)name:,description:,tools:, anduser-invocable: trueto all agent files (PR Streamline agent documentation for 1.0.0 release #73 from template).gitattributes: Added to enforce LF line endings for consistent file fingerprints across platforms (PR [Feature]: Add SBOM Generation #71 from template).reviewmark.yaml: Added ReviewMark integration with ReqStream-specific review sets (PR Consolidate CI workflows for full integration testing across all platforms #58 from template)pip-requirements.txt: Added Python dependencies (yamllint==1.38.0) for venv-based linting (PR Consolidate CI workflows for full integration testing across all platforms #58 from template)lint.sh/lint.bat: Rewritten to use Python venv + pip pattern; accumulate errors instead of failing fast (PR Consolidate CI workflows for full integration testing across all platforms #58/[Feature]: Fix SonarQube Duplicate Code Issue #61 from template)package.json: Updated with pinnedcspell@9.7.0andmarkdownlint-cli2@0.21.0devDependencies (PR Consolidate CI workflows for full integration testing across all platforms #58 from template).config/dotnet-tools.json: Addeddemaconsulting.reviewmarktool (PR Consolidate CI workflows for full integration testing across all platforms #58 from template).versionmark.yaml: Addedreviewmarkentry; updated regex patterns to support pre-release versions (PR Add --enforce flag for requirements coverage validation in CI #54/Consolidate CI workflows for full integration testing across all platforms #58 from template).gitignore: Restructured to match template; added Python.venvsection and review plan/report exclusions (PR Consolidate CI workflows for full integration testing across all platforms #58 from template)code-review.agent.md: Added new code review agent definition (PR [Feature]: Enforce requirements coverage #59 from template)AGENTS.md: Added code review agent to available agents list and spell check word list policy (PR [Feature]: Enforce requirements coverage #59/[Feature]: Architecture Documentation #63 from template).cspell.jsonto.cspell.yamlwith policy header comments and additional technical terms (PRs [Feature]: Fix SonarQube Duplicate Code Issue #61/[Feature]: Architecture Documentation #63 from template).markdownlint-cli2.jsoncto.markdownlint-cli2.yamlwith PURPOSE/DO NOT MODIFY header (PR [Feature]: Fix SonarQube Duplicate Code Issue #61/Add ARCHITECTURE.md documenting internal design and processing flows #64 from template)CONTRIBUTING.md: Comprehensive rewrite matching template standards with ReqStream-specific translation (PR [Feature]: Fix SonarQube Duplicate Code Issue #61 from template)code-quality.agent.md: Updated to comprehensive template version (PR [Feature]: SonarQube cleanup #65–Streamline agent documentation for 1.0.0 release #73 from template)Type of Change
Related Issues
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.ReqStream --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"— 0 issuesmarkdownlint "**/*.md"— 0 errorsyamllint .— 0 errorsTesting
Documentation
Additional Notes
All changes are infrastructure/tooling improvements (agent files, linting configs, git configuration, ReviewMark integration) with no impact on ReqStream's production C# code or test coverage.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.