Apply TemplateDotNetTool PRs #65–#74 to SarifMark

[Copilot]

Applies recent changes merged into the TemplateDotNetTool template repository (PRs #65–#74) to keep SarifMark consistent with the template.

Description

PR #71 — Add .gitattributes

Added .gitattributes to enforce LF line endings for all text files (with CRLF preserved for .bat/.cmd), ensuring consistent SHA256 fingerprints for ReviewMark across Windows and Linux platforms.

PR #65 — Docs folder renames and reference updates

Renamed all documentation output folders to use underscore-separated naming convention:

Old	New
docs/buildnotes/	docs/build_notes/
docs/quality/	docs/code_quality/
docs/reviewplan/	docs/code_review_plan/
docs/reviewreport/	docs/code_review_report/
docs/requirements/	docs/requirements_doc/
docs/justifications/	merged into docs/requirements_doc/
docs/tracematrix/	docs/requirements_report/

All references updated across: definition.yaml files, .gitignore, .cspell.yaml, build.yaml, release.yaml, .reviewmark.yaml, pull_request_template.md, and AGENTS.md.

Also adds docs/reqstream/**/*.yaml and !**/bin/** to .reviewmark.yaml needs-review patterns.

PR #70 — Bump BuildMark version

Bumped demaconsulting.buildmark from 0.4.0 → 0.4.1 in .config/dotnet-tools.json.

PR #72 — Simplify repo-consistency.agent.md

Replaced the verbose 159-line agent file with the simplified 37-line actionable version: 3 consistency steps, updated tools: [read, search, edit, execute, github, agent], and user-invocable: true.

PRs #66, #70 — Simplify code-review.agent.md

Updated to the simplified 4-step review structure with correct tools: [read, search, edit, execute, github, web, agent], user-invocable: true, and canonical report naming (AGENT_REPORT_code_review_[review-set].md).

PR #66 — Agent frontmatter updates + AGENTS.md

Added user-invocable: true and updated tools arrays for all remaining agents. Added Agent Report Files section to AGENTS.md documenting the AGENT_REPORT_*.md naming convention (already enforced in .gitignore, markdownlint, and cspell configs).

PR #73 — Correct agent tools: frontmatter

Updated tools: lists in all 7 agent files to add missing tools and reorder consistently:

Agent	Final tools:
code-quality	[read, search, edit, execute, github, agent]
code-review	[read, search, edit, execute, github, web, agent]
repo-consistency	[read, search, edit, execute, github, agent]
requirements	[read, search, edit, execute, github, web, agent]
software-developer	[read, search, edit, execute, github, agent]
technical-writer	[read, search, edit, execute, github, agent]
test-developer	[read, search, edit, execute, github, agent]

PR #74 — Fix repo-consistency agent PR search order

Updated the repo-consistency agent to use sort:updated-desc in its merged PR search query (is:pr is:merged sort:updated-desc), so it fetches the 20 most recently merged PRs instead of the 20 oldest. Since GitHub's search API has no sort:merged qualifier, sort:updated-desc serves as the best available proxy for merge recency.

Bug fix — build_notes.html filename

Fixed docs/build_notes/buildnotes.html → docs/build_notes/build_notes.html in build.yaml (both the Pandoc output step and the WeasyPrint input step). The old filename contained buildnotes, which was removed from the .cspell.yaml word list as part of the folder renames, and would have caused CI spellcheck failures.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.SarifMark --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

No production code or tests were modified. All changes are structural (docs folder renames, config path updates) and agent/compliance alignment with the TemplateDotNetTool template. The justifications folder content was merged into requirements_doc/ using prefixed filenames (justifications-definition.yaml, etc.) to preserve SarifMark's separate Requirements Justifications PDF while following the template's naming convention.

---

⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

[Malcolmnixon]

@copilot Please try applying the updates from the TemplateDotNetTool repository again to pull in some recent PRs that just got merged.

[Copilot]

@copilot Please try applying the updates from the TemplateDotNetTool repository again to pull in some recent PRs that just got merged.

Applied changes from TemplateDotNetTool PRs #65–#72 in commit bece2de:

PR #71 — Added .gitattributes to enforce LF line endings for consistent reviewmark fingerprints.

PR #65 — Renamed docs folders to underscore convention: buildnotes/→build_notes/, quality/→code_quality/, reviewplan/→code_review_plan/, reviewreport/→code_review_report/, requirements/→requirements_doc/, justifications/→merged into requirements_doc/, tracematrix/→requirements_report/. Updated all definition.yaml files, .gitignore, .cspell.yaml, build.yaml, release.yaml, .reviewmark.yaml, pull_request_template.md, and AGENTS.md.

PR #70 — Bumped buildmark to 0.4.1 in .config/dotnet-tools.json.

PR #72 — Replaced verbose repo-consistency.agent.md (~159 lines) with the simplified 3-step actionable version.

PRs #66, #70 — Updated code-review.agent.md to simplified template-aligned structure with correct report naming convention.

PR #66 — Added user-invocable: true frontmatter and updated tools arrays for all five remaining agents (requirements, technical-writer, test-developer, software-developer, code-quality). Added Agent Report Files section to AGENTS.md.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[Copilot]

Pull request overview

This PR syncs SarifMark with recent TemplateDotNetTool template updates (PRs #65–#72), primarily standardizing documentation output folder names, updating build/release pipelines to match the new paths, and aligning Copilot agent frontmatter with the template.

Changes:

• Rename docs output folders to underscore-separated naming (e.g., docs/build_notes/, docs/code_quality/, docs/requirements_doc/, etc.) and update references across workflows/configs.
• Add .gitattributes to normalize text line endings to LF (preserving CRLF for .bat/.cmd) to stabilize ReviewMark fingerprints cross-platform.
• Update agent frontmatter (tools/user-invocable) and bump demaconsulting.buildmark to 0.4.1.

Reviewed changes

Copilot reviewed 29 out of 44 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
docs/tracematrix/definition.yaml	Removes old trace matrix pandoc defaults from legacy folder path.
docs/reviewreport/definition.yaml	Removes old review report pandoc defaults from legacy folder path.
docs/reviewplan/definition.yaml	Removes old review plan pandoc defaults from legacy folder path.
docs/requirements_report/title.txt	Adds new requirements report (trace matrix) title frontmatter under underscore folder.
docs/requirements_report/introduction.md	Adds new trace matrix introduction content under underscore folder.
docs/requirements_report/definition.yaml	Adds new trace matrix pandoc defaults pointing at trace_matrix.md.
docs/requirements_doc/title.txt	Adds new requirements doc title frontmatter under underscore folder.
docs/requirements_doc/justifications-title.txt	Adds new requirements justifications title frontmatter under merged requirements_doc/.
docs/requirements_doc/justifications-introduction.md	Adds new requirements justifications introduction under merged requirements_doc/.
docs/requirements_doc/justifications-definition.yaml	Adds new pandoc defaults for requirements justifications document.
docs/requirements_doc/introduction.md	Adds new requirements introduction under underscore folder.
docs/requirements_doc/definition.yaml	Adds new pandoc defaults for requirements document.
docs/requirements/definition.yaml	Removes old requirements pandoc defaults from legacy folder path.
docs/quality/definition.yaml	Removes old code quality pandoc defaults from legacy folder path.
docs/justifications/definition.yaml	Removes old justifications pandoc defaults from legacy folder path.
docs/code_review_report/title.txt	Adds new code review report title frontmatter under underscore folder.
docs/code_review_report/introduction.md	Adds new code review report introduction under underscore folder.
docs/code_review_report/definition.yaml	Adds new pandoc defaults for code review report.
docs/code_review_plan/title.txt	Adds new code review plan title frontmatter under underscore folder.
docs/code_review_plan/introduction.md	Adds new code review plan introduction under underscore folder.
docs/code_review_plan/definition.yaml	Adds new pandoc defaults for code review plan.
docs/code_quality/title.txt	Adds new code quality title frontmatter under underscore folder.
docs/code_quality/introduction.md	Adds new code quality introduction under underscore folder.
docs/code_quality/definition.yaml	Adds new pandoc defaults for code quality report.
docs/buildnotes/definition.yaml	Removes old build notes pandoc defaults from legacy folder path.
docs/build_notes/title.txt	Adds new build notes title frontmatter under underscore folder.
docs/build_notes/introduction.md	Adds new build notes introduction under underscore folder.
docs/build_notes/definition.yaml	Adds new build notes pandoc defaults under underscore folder.
AGENTS.md	Updates key-file pointers for reqstream-based requirements and documents AGENT_REPORT_*.md convention.
.reviewmark.yaml	Adds docs/reqstream/**/*.yaml and !**/bin/** to review-needed patterns.
.gitignore	Updates ignored generated-doc paths to new underscore folder structure.
.github/workflows/release.yaml	Updates build notes filename/path to build_notes.md.
.github/workflows/build.yaml	Updates reqstream/pandoc/weasyprint paths to new underscore doc structure.
.github/pull_request_template.md	Simplifies linter checklist to the unified lint.* scripts.
.github/agents/test-developer.agent.md	Reorders tools and marks agent as user-invocable.
.github/agents/technical-writer.agent.md	Adds execute and marks agent as user-invocable.
.github/agents/software-developer.agent.md	Adds github and marks agent as user-invocable.
.github/agents/requirements.agent.md	Updates tools list and marks agent as user-invocable.
.github/agents/repo-consistency.agent.md	Replaces verbose guidance with a short actionable consistency workflow and updated tools.
.github/agents/code-review.agent.md	Simplifies formal review guidance, adds reporting naming convention, updates tools.
.github/agents/code-quality.agent.md	Adds edit/github and marks agent as user-invocable.
.gitattributes	Adds LF normalization defaults (CRLF for .bat/.cmd).
.cspell.yaml	Updates allowed words for underscore doc folder naming.
.config/dotnet-tools.json	Bumps demaconsulting.buildmark to 0.4.1.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Malcolmnixon]

@copilot Please also merge in demaconsulting/TemplateDotNetTool#73

[Copilot]

@copilot Please also merge in demaconsulting/TemplateDotNetTool#73

Applied TemplateDotNetTool PR #73 in commit 324d404. Updated the tools: frontmatter for all 7 agent files to match the template (adding agent, web, execute, github where missing and reordering consistently):

Agent	Before	After
code-quality	[edit, read, search, execute, github]	[read, search, edit, execute, github, agent]
code-review	[read, search, github, agent, execute]	[read, search, edit, execute, github, web, agent]
repo-consistency	[edit, read, search, github, agent]	[read, search, edit, execute, github, agent]
requirements	[edit, read, search, execute]	[read, search, edit, execute, github, web, agent]
software-developer	[edit, read, search, execute, github]	[read, search, edit, execute, github, agent]
technical-writer	[edit, read, search, execute]	[read, search, edit, execute, github, agent]
test-developer	[edit, read, search, execute]	[read, search, edit, execute, github, agent]

Also fixed a buildnotes.html → build_notes.html filename bug in build.yaml that would have caused cspell CI failures (since buildnotes was removed from the word list).

[Malcolmnixon]

@copilot Please also merge in demaconsulting/TemplateDotNetTool#74

[Copilot]

@copilot Please also merge in demaconsulting/TemplateDotNetTool#74

Applied PR #74 in commit 9f8865e. Updated the repo-consistency agent to use sort:updated-desc when fetching merged PRs so it retrieves the 20 most recently merged PRs instead of the 20 oldest.