Bring in latest repo-consistency agent and apply template improvements from TemplateDotNetTool

[Copilot]

Pull Request

Description

Syncs SpdxTool with TemplateDotNetTool template improvements (PRs #58–#74). First updates the repo-consistency agent to the new simplified 3-step format, then applies all outstanding template changes.

Repo-Consistency Agent (template PRs #72–#74)

• Replaced ~130-line detailed agent with concise 3-step process format
• Added proper YAML frontmatter: tools: [read, search, edit, execute, github, agent], user-invocable: true
• Fixed PR fetch order (sort:updated-desc to get most-recently-merged, not oldest)

Linting Modernization (template PR #61, #63, #64)

• Renamed .cspell.json → .cspell.yaml and .markdownlint-cli2.jsonc → .markdownlint-cli2.yaml (YAML format with policy header comments)
• Updated .yamllint.yaml with header comments and ignore: block
• Updated lint.sh/lint.bat to install npm/pip deps, accumulate errors rather than early-exit
• Added pip-requirements.txt pinning yamllint==1.38.0
• Updated package.json to use devDependencies with explicit cspell and markdownlint-cli2 entries

Agent File Standardization (template PR #61, #65–#70, #73)

• Renamed all agent files from *-agent.md/*.md → *.agent.md
• Added YAML frontmatter (name, description, tools, user-invocable) to all agent files
• Updated agent content to latest template versions

ReviewMark Integration (template PR #58–#59)

• Added .reviewmark.yaml with SpdxTool-specific review sets (Context, Program, Commands, Utility, Targets units)
• Added demaconsulting.reviewmark v0.1.0 to .config/dotnet-tools.json; bumped buildmark to v0.4.1
• Added code-review.agent.md and updated AGENTS.md with Code Review Agent entry

Git & CI

• Added .gitattributes enforcing LF line endings (*.bat/*.cmd exempt) for consistent ReviewMark SHA256 fingerprints
• Updated build.yaml to reference new .cspell.yaml/.markdownlint-cli2.yaml filenames
• Added .venv/ to .gitignore

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

• Code builds successfully: dotnet build --configuration Release
• All unit tests pass: dotnet test --configuration Release
• Self-validation tests pass:
  dotnet run --project src/DemaConsulting.SpdxTool --configuration Release --framework net10.0
--no-build -- --validate
• Code produces zero warnings

Code Quality

• Code formatting is correct: dotnet format --verify-no-changes
• New code has appropriate XML documentation comments
• Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

• Spell checker passes: cspell "**/*.{md,cs}"
• Markdown linter passes: markdownlint "**/*.md"
• YAML linter passes: yamllint .

Testing

• Added unit tests for new functionality
• Updated existing tests if behavior changed
• All tests follow the AAA (Arrange, Act, Assert) pattern
• Test coverage is maintained or improved

Documentation

• Updated README.md (if applicable)
• Updated ARCHITECTURE.md (if applicable)
• Added code examples for new features (if applicable)
• Updated requirements.yaml (if applicable)

Additional Notes

No production code changed — all modifications are tooling configuration, agent instructions, and CI/CD infrastructure. The ReviewMark --enforce flag is intentionally not enabled until the reviews branch is populated with review evidence.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
  • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

---

⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.