Skip to content

Add .gitattributes to enforce LF line endings for consistent reviewmark fingerprints#71

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-pull-62-from-template-dotnet-library
Mar 24, 2026
Merged

Add .gitattributes to enforce LF line endings for consistent reviewmark fingerprints#71
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-pull-62-from-template-dotnet-library

Conversation

Copy link
Contributor

Copilot AI commented Mar 24, 2026

Pull Request

Description

reviewmark uses SHA256 fingerprints to detect file modifications. Git's platform-dependent line-ending normalization causes fingerprint mismatches across Windows and Unix environments. Adding .gitattributes enforces consistent LF checkout for all text files, with CRLF preserved for .bat/.cmd files that require it.

  • .gitattributes (new):
    • * text=auto eol=lf — all text files normalized to LF on checkout
    • *.bat / *.cmd — explicitly eol=crlf for correct Windows batch execution

Ports demaconsulting/TemplateDotNetLibrary#62.

Note for Windows developers: After merge, re-normalize checked-out files with git add --renormalize ..

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Related Issues

Pre-Submission Checklist

Before submitting this pull request, ensure you have completed the following:

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Self-validation tests pass:
    dotnet run --project src/DemaConsulting.TemplateDotNetTool --configuration Release --framework net10.0
    --no-build -- --validate
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

Please run the following checks before submitting:

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

Configuration-only change — no executable code modified.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Add pull request #62 from TemplateDotNetLibrary Add .gitattributes to enforce LF line endings for consistent reviewmark fingerprints Mar 24, 2026
Copilot AI requested a review from Malcolmnixon March 24, 2026 00:09
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 24, 2026 00:12
Copilot AI review requested due to automatic review settings March 24, 2026 00:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a repository-level Git configuration to make line endings deterministic across platforms, preventing reviewmark SHA256 fingerprint drift between Windows and Unix checkouts.

Changes:

  • Introduces .gitattributes to force LF for all text files.
  • Adds explicit CRLF checkout behavior for Windows batch files (.bat, .cmd).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon merged commit da17e86 into main Mar 24, 2026
19 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/bring-in-pull-62-from-template-dotnet-library branch March 24, 2026 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants