Skip to content

chore: apply recent template changes from TemplateDotNetLibrary#126

Merged
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-recent-template-changes
Mar 24, 2026
Merged

chore: apply recent template changes from TemplateDotNetLibrary#126
Malcolmnixon merged 2 commits intomainfrom
copilot/bring-in-recent-template-changes

Conversation

Copy link
Contributor

Copilot AI commented Mar 24, 2026

Reviewed recent merged PRs from demaconsulting/TemplateDotNetLibrary using the GitHub API and applied the identified template drift corrections to the TestResults repository.

Description

The following changes were applied from template PRs #47, #55, #56, #57, #61, and #62:

The following files were verified as already aligned with the current template and required no changes: AGENTS.md, repo-consistency.agent.md, test-developer.agent.md, and the ots-{component}.yaml naming pattern in requirements.agent.md.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code quality improvement

Pre-Submission Checklist

Build and Test

  • Code builds successfully: dotnet build --configuration Release
  • All unit tests pass: dotnet test --configuration Release
  • Code produces zero warnings

Code Quality

  • Code formatting is correct: dotnet format --verify-no-changes
  • New code has appropriate XML documentation comments
  • Static analyzer warnings have been addressed

Quality Checks

  • All linters pass: ./lint.sh (Unix/macOS) or cmd /c lint.bat / ./lint.bat (Windows)

Testing

  • Added unit tests for new functionality
  • Updated existing tests if behavior changed
  • All tests follow the AAA (Arrange, Act, Assert) pattern
  • Test coverage is maintained or improved

Documentation

  • Updated README.md (if applicable)
  • Updated ARCHITECTURE.md (if applicable)
  • Added code examples for new features (if applicable)
  • Updated requirements.yaml (if applicable)

Additional Notes

All spell check issues found during linting were confirmed to be pre-existing (present before these changes) and are not introduced by this PR.


⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.

Copilot AI changed the title [WIP] Update project with recent changes from the template chore: template consistency analysis for TestResults Mar 24, 2026
Copilot AI requested a review from Malcolmnixon March 24, 2026 00:23
@Malcolmnixon
Copy link
Contributor

@copilot It seems you failed to review the pull requests and apply any changes... what gives?

…57, #61-62

- Simplify .gitattributes to use global eol=lf for consistent reviewmark fingerprints (PR #62)
- Rewrite code-review.agent.md with simplified template version and add agent/execute tools (PR #55, #56, #57, #61)
- Bump DemaConsulting.BuildMark from 0.4.0 to 0.4.1 (PR #57)
- Update raw.githubusercontent.com URLs to github.com/raw/ format in requirements.agent.md (PR #56)
- Update raw.githubusercontent.com URLs to github.com/raw/ format in technical-writer.agent.md (PR #56)
- Add reqstream (lowercase) to .cspell.yaml word list (PR #47)

Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Agent-Logs-Url: https://github.com/demaconsulting/TestResults/sessions/a76dd3fa-5fc8-4f4a-88cc-35d7e1eee9ae
Copy link
Contributor Author

Copilot AI commented Mar 24, 2026

@copilot It seems you failed to review the pull requests and apply any changes... what gives?

Applied in commit 985ab77. Here's what was brought in from the template PRs:

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chromium-browser-snapshots/Linux_x64/1108766/chrome-linux.zip
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title chore: template consistency analysis for TestResults chore: apply recent template changes from TemplateDotNetLibrary Mar 24, 2026
@Malcolmnixon Malcolmnixon marked this pull request as ready for review March 24, 2026 00:47
Copilot AI review requested due to automatic review settings March 24, 2026 00:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the TestResults repository with recent TemplateDotNetLibrary template updates, primarily around agent guidance, tooling, and cross-platform consistency for compliance workflows (ReqStream/ReviewMark).

Changes:

  • Simplifies .gitattributes to enforce LF line endings globally (with CRLF exceptions for .bat/.cmd) to stabilize ReviewMark fingerprints across platforms.
  • Updates agent documentation to the latest template (notably a rewritten code-review agent and updated ContinuousCompliance raw URL format).
  • Refreshes tooling/spellcheck config (bump demaconsulting.buildmark and add reqstream to cspell dictionary).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.gitattributes Enforces consistent LF endings (CRLF for batch files) to reduce cross-platform fingerprint drift.
.github/agents/code-review.agent.md Replaces prior long-form guidance with streamlined template instructions and updated tool list.
.github/agents/requirements.agent.md Updates ContinuousCompliance links to the newer github.com/.../raw/... format.
.github/agents/technical-writer.agent.md Updates reference-style link targets to the newer raw URL format.
.config/dotnet-tools.json Bumps demaconsulting.buildmark from 0.4.0 to 0.4.1.
.cspell.yaml Adds reqstream (lowercase) to the allowed word list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Malcolmnixon Malcolmnixon merged commit b830cef into main Mar 24, 2026
12 checks passed
@Malcolmnixon Malcolmnixon deleted the copilot/bring-in-recent-template-changes branch March 24, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants