-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Unit42 Intelligence change hard coded source reliability in relationships to use parameter. #42933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lehrbaumm
wants to merge
9
commits into
demisto:contrib/lehrbaumm_unit42_fix_reliability
Choose a base branch
from
lehrbaumm:unit42_fix_reliability
base: contrib/lehrbaumm_unit42_fix_reliability
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5712a5a
Update Unit42Intelligence.py relationship reliability
lehrbaumm e5fef45
Create ReleaseNotes for Unit42 Intelligence Pack
lehrbaumm e73829f
Update pack_metadata.json
lehrbaumm c25b4e8
Create CONTRIBUTORS.json
lehrbaumm e5cbb22
Update Unit42Intelligence.py
lehrbaumm f3f6ebd
Merge branch 'contrib/lehrbaumm_unit42_fix_reliability' into unit42_f…
MosheEichler b448718
Reverted formating changes
lehrbaumm dea2a16
Merge branch 'contrib/lehrbaumm_unit42_fix_reliability' into unit42_f…
MosheEichler 6710c06
Update Packs/Unit42ThreatIntelligencebyPaloAltoNetworks/ReleaseNotes/…
MosheEichler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
Packs/Unit42ThreatIntelligencebyPaloAltoNetworks/CONTRIBUTORS.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| [ | ||
| "Maximilian Lehrbaum" | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
Packs/Unit42ThreatIntelligencebyPaloAltoNetworks/ReleaseNotes/1_0_12.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| #### Integrations | ||
|
|
||
| ##### Unit 42 Intelligence | ||
|
|
||
| - Changed `create_relationships` to use the `reliability` parameter for `source_reliability`, allowing for configurable reliability levels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the docstring to include the new
reliabilityparameter.This also applies to the following functions where the parameter was added:
create_threat_object_relationshipscreate_campaigns_relationshipscreate_attack_patterns_relationshipscreate_malware_relationshipscreate_tools_relationshipscreate_vulnerabilities_relationshipscreate_actor_relationshipscreate_location_indicators_and_relationships