Unit42 Intelligence change hard coded source reliability in relationships to use parameter.#42933
Conversation
Instance parameter for custom reliability also added to relationship creations.
content-bot
added
Contribution
content-bot
changed the base branch from
master
to
contrib/lehrbaumm_unit42_fix_reliability
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @kamalq97 will know the proposed changes are ready to be reviewed. |
|
Hi @lehrbaumm, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link. |
🤖 AI-Powered Code Review AvailableHi @kamalq97, you can leverage AI-powered code review to assist with this PR! Available Commands:
|
content-bot
added
Community
Contribution Form Filled
Formating fixed
MosheEichler
left a comment
MosheEichler
left a comment
There was a problem hiding this comment.
Hi @lehrbaumm,
Thank you for your contribution!
Good work :)
Pleases revert all not relevant changes (e.g. single quote to double quote etc. in general all format changes)
Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again
MosheEichler
added
the
pending-contributor
MosheEichler
added
ready-for-instance-test
|
For the Reviewer: Trigger build request has been accepted for this contribution PR. |
|
For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/7028271 |
content-bot
removed
ready-for-instance-test
|
🤖 Content AI Reviewer: Analysis started. Please wait for results... |
Packs/Unit42ThreatIntelligencebyPaloAltoNetworks/ReleaseNotes/1_0_12.md
Outdated
Show resolved
Hide resolved
…1_0_12.md Co-authored-by: Richard Bluestone <53567272+richardbluestone@users.noreply.github.com>
🤖 Content-bot Review DisclaimerThis review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause. |
content-bot
left a comment
content-bot
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I've reviewed the changes and have a few minor items to address.
Please update the docstrings for all functions utilizing the new reliability parameter to ensure they are documented correctly. Additionally, the release notes require some formatting adjustments to match our standard conventions.
Nice work!
@kamalq97, @MosheEichler please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.
| indicator_type: str, | ||
| threat_objects: list[dict[str, Any]], | ||
| create_relationships: bool, | ||
| reliability: str = DBotScoreReliability.A_PLUS_PLUS, |
There was a problem hiding this comment.
Please update the docstring to include the new reliability parameter.
This also applies to the following functions where the parameter was added:
create_threat_object_relationshipscreate_campaigns_relationshipscreate_attack_patterns_relationshipscreate_malware_relationshipscreate_tools_relationshipscreate_vulnerabilities_relationshipscreate_actor_relationshipscreate_location_indicators_and_relationships
|
|
||
| ##### Unit 42 Intelligence | ||
|
|
||
| - Change relationship source_reliability to use parameter reliability. |
There was a problem hiding this comment.
Please use a standard prefix for the release note (e.g., 'Updated the') and format parameter/function names with single stars (*) instead of backticks.
5 participants
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Must have
relates: https://jira-dc.paloaltonetworks.com/browse/CIAC-15699