Skip to content

Cyfirma decyfir crtx 166141#42940

Open
tmizrahiPA wants to merge 6 commits intomasterfrom
cyfirma_decyfir_CRTX-166141
Open

Cyfirma decyfir crtx 166141#42940
tmizrahiPA wants to merge 6 commits intomasterfrom
cyfirma_decyfir_CRTX-166141

Conversation

@tmizrahiPA
Copy link
Contributor

@tmizrahiPA tmizrahiPA commented Feb 5, 2026

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

CRTX-166141

Description

Cyfirma's DeCYFIR mapping pack

Must have

  • Tests
  • Documentation

@tmizrahiPA tmizrahiPA added bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Feb 5, 2026
@tmizrahiPA
Copy link
Contributor Author

tmizrahiPA commented Feb 5, 2026 •
edited
Loading

@content-bot start review

@tmizrahiPA tmizrahiPA added the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Feb 5, 2026
@content-bot
Copy link
Contributor

content-bot commented Feb 5, 2026

🤖 AI-Powered Code Review Available

You can leverage AI-powered code review to assist with this PR!

Available Commands:

  • @content-bot start review - Initiate a full AI code review
  • @content-bot re-review - Incremental review for new commits

@richardbluestone richardbluestone requested review from julieschwartz18 and removed request for richardbluestone February 5, 2026 10:36
julieschwartz18
julieschwartz18 reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@julieschwartz18 julieschwartz18 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmizrahiPA Doc review complete. Please review the comments. In the meantime, adding the label docs-approved. Thanks!

@tmizrahiPA
Copy link
Contributor Author

tmizrahiPA commented Feb 5, 2026

@content-bot start review

@content-bot content-bot removed the ready-for-ai-review The PR is ready for reviewing the PR with the AI Reviewer. label Feb 5, 2026
@content-bot
Copy link
Contributor

content-bot commented Feb 5, 2026

🤖 Content AI Reviewer: Analysis started. Please wait for results...

eepstain
eepstain reviewed Feb 5, 2026
View reviewed changes
@content-bot
Copy link
Contributor

content-bot commented Feb 5, 2026

🤖 Content-bot Review Disclaimer

This review was generated by an AI-powered tool and may contain inaccuracies. Please be advised, and we extend our sincere apologies for any inconvenience this may cause.

content-bot
content-bot reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@content-bot content-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to the DeCYFIR pack! I noticed a few metadata issues, specifically regarding the version number needing a bump and missing release notes. Please also review the README for some formatting inconsistencies and visibility tags that might hide content from XSIAM users, and double-check the modeling rule logic regarding fallback values.

Great work otherwise!

@julieschwartz18, @eepstain please review and approve the results generated by the AI Reviewer by responding 👍 on this comment.

@content-bot
Copy link
Contributor

content-bot commented Feb 5, 2026

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@content-bot content-bot content-bot left review comments

@julieschwartz18 julieschwartz18 julieschwartz18 left review comments

@eepstain eepstain eepstain approved these changes

Assignees

No one assigned

Labels

bypass.url Whether to create build bucket, add this label for marketplace.bootstrap.bypass.url docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tmizrahiPA @content-bot @julieschwartz18 @eepstain