feat: enhance notification details #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new "Backup Details Sheet" feature in the web app, allowing users to view detailed information about failed backups directly from the notification sidebar. It also updates the backend to support richer notification metadata, enabling the frontend to display more contextual error information. The changes span both the backend (API) and frontend (web app), focusing on improved error visibility and user experience for failed backup events.
Backend: Notification Metadata Support
metadatafield of typejson.RawMessageto theNotificationListstruct, and updated SQL queries and row scanning logic to include this field when fetching user notifications. This allows notifications to carry additional structured data, such as backup error details. [1] [2] [3]Frontend: Backup Error Details Sheet
BackupDetailsSheet, which displays detailed information about a backup (especially failed ones), including error messages from related notifications, database info, timing, and attempted backup paths.BackupDetailsSheetinto theHistoryListview, allowing it to open when a notification is clicked. When a failed backup notification is clicked, a synthetic backup object is created from the notification metadata to populate the details sheet. [1] [2] [3] [4]NotificationSidebarcomponent to accept anonNotificationClickprop and trigger it when a notification is clicked, enabling the new interaction. Also improved the visual feedback for notification selection. [1] [2]