Skip to content

Fix: Prevent null return in database discovery API #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dendianugerah merged 1 commit into from
Nov 25, 2025
Merged

Fix: Prevent null return in database discovery API #67

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions apps/api/internal/connection/connection_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,11 @@ func (cm *ConnectionManager) DiscoverDatabases(config ConnectionConfig) ([]strin
return nil, fmt.Errorf("unsupported database type for discovery: %s", config.Type)
}

// Ensure we never return nil, always return an empty array
if databases == nil {
databases = []string{}
}

return databases, err
}

Expand All @@ -353,7 +358,7 @@ func (cm *ConnectionManager) discoverPostgresDatabases(db *sql.DB) ([]string, er
}
defer rows.Close()

var databases []string
databases := []string{}
for rows.Next() {
var dbName string
if err := rows.Scan(&dbName); err != nil {
Expand All @@ -379,7 +384,7 @@ func (cm *ConnectionManager) discoverMySQLDatabases(db *sql.DB) ([]string, error
}
defer rows.Close()

var databases []string
databases := []string{}
for rows.Next() {
var dbName string
if err := rows.Scan(&dbName); err != nil {
Expand All @@ -400,7 +405,7 @@ func (cm *ConnectionManager) discoverMongoDBDatabases(client *mongo.Client) ([]s
}

// Filter out system databases
var filtered []string
filtered := []string{}
for _, db := range databases {
if db != "admin" && db != "local" && db != "config" {
filtered = append(filtered, db)
Expand Down