Rum

[bamarco]

rum plugin

[bamarco]

@denistakeda Maybe now it will work?

[denistakeda]

@bamarco . Unfortunately, I still can not merge it :-( A bit later I'll move the differences manually to another PR and provide it to you for review.

[denistakeda]

Hello @bamarco . I tried to manually recreate your PR, but run into the issue. The thing is, it looks like there is no such thing as reagent.ratom/make-reaction in the clojure version of namespace https://github.com/reagent-project/reagent/blob/master/src/reagent/ratom.clj
So when I tried to run tests with this code they failed to compile with a message:

Syntax error compiling at (posh/reagent.cljc:9:3).
No such var: ra/make-reaction

Could you please have a look at this?

[fpischedda]

@denistakeda

Hi! I would like to help integrate Posh with Rum, is this PR still relevant?

If I am not mistaken you started to cleanup this PR but then got stuck; I may propose a couple of things:

• if you have a cleaner branch I can try to take over it (preferred)
• restart from this PR
• start again from scratch

Let me know if and how I can help!

[denistakeda]

Hello @fpischedda . Basically this PR is mostly finished work, the only problem is that it breaks tests. The reason for it is that we need to test in both Clojure and ClojureScript, but reagent doesn't provide make-reaction for Clojure.
It would be great if you can take over this. So I think that the way to proceed is:

• Take this branch
• Rebase to a latest master
• Fix a problem with tests
• Create a new PR

[denistakeda]

Also, I would like to have some more declarative way to work with rum, something like re-posh for reagent. But this is a plan for the future.

[fpischedda]

@denistakeda

Thanks for your quick reply and for clarifying what needs to be done. I'll get back to you as soon as I have something ready or if I will need some help :)

Regarding something like re-posh for rum/citrus, it would be great to have it some day! If I will get familiar enough with both project internals it would be something I will be excited to work on, let's see what happens with this topic first.