correction for gem name as specified in gemspec#7
Open
jaeming wants to merge 1 commit intodenkGroot:masterfrom
jaeming:patch-1
Open
correction for gem name as specified in gemspec#7jaeming wants to merge 1 commit intodenkGroot:masterfrom jaeming:patch-1
jaeming wants to merge 1 commit intodenkGroot:masterfrom
jaeming:patch-1
Conversation
I believe you left of the 's' on reviews here. It wouldn't bundle and when I looked at the gemspec, the gem name was "spina-reviews" as opposed to ""spina-review" as you have listed in this snippet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe you left of the 's' on reviews here. It wouldn't bundle and when I looked at the gemspec, the gem name was "spina-reviews" as opposed to "spina-review" as you have listed in this snippet.