Merged
Conversation
This update addresses a dependency version conflict and aligns with the latest rusqlite API changes. In rusqlite 0.35+, the DatabaseName enum was removed in favor of using string literals directly for database names. This change simplifies the API by using SQLite's native string-based naming convention. Changes: - Updated rusqlite dependency from 0.34.0 to 0.37.0 - Removed DatabaseName import from sqlite/backend.rs - Replaced DatabaseName::Main with "main" string literal in is_readonly() call All existing tests pass with these changes.
marvinhagemeister
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #131