fix(urlpattern): remove inline (?u) flag from regex generation
#74
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(urlpattern): remove inline (?u) flag in regex generation to resolve invalid-group error in URLPattern
related issue:
fixes #31072
The inline (?u) flag was being embedded regardless of context and caused certain regex constructs to misbehave in the JavaScript environment.
How
• Edited regexp.rs to no longer prepend inline flags such as (?u) to the pattern.
• Updated tests to cover alternation use-cases:
• /install.sh → match true
• /install.ps1 → match true
• install.exe, install.sh/extra → match false
• Ensured no regression for wildcard or other pattern types.