Add critical unit tests for vault root, updates, browser, clone (2026-04-02)#198
Merged
Add critical unit tests for vault root, updates, browser, clone (2026-04-02)#198
Conversation
…clone UI Move vault root walking into VaultRootResolver (used by SynapseAppDelegate). Centralize update banner strings, mini-browser URL normalization, and clone sheet validation in small enums so behavior can be covered by unit tests. Co-authored-by: Danny Peck <dannypeck@gmail.com>
…rows Cover Finder open-file vault resolution, update banner copy, in-app browser URL normalization, clone sheet enablement, and FileSearchResult identity. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds focused unit tests for five high-impact flows, with small extracted helpers so the behavior stays testable without spinning up SwiftUI.
Areas covered
VaultRootResolver) — opening a file from Finder resolves the vault that contains.synapseon an ancestor.UpdateBannerCopy) — titles, subtitles, and SF Symbol names for install / download / restart states.MiniBrowserURLNormalizer) — HTTPS defaulting, trimming, preserving explicithttp/https.CloneRepositoryValidation) — Clone is enabled only when URL is non-empty and a destination folder is chosen.FileSearchResult) — per-instanceIdentifiableids and stored fields.CI
.github/workflows/tests.ymlalready runsxcodebuild teston pull requests; no change required.Reviewer
Please assign @dep as reviewer.
Environment
The automation host is Linux-only; macOS CI should confirm all tests pass.