fix(mobile): reconcile GitHub API vault files when commit SHA unchanged#201
Merged
fix(mobile): reconcile GitHub API vault files when commit SHA unchanged#201
Conversation
…anged refreshViaGitHubApi returned early when remote commit SHA matched stored metadata, skipping blob reconciliation. That breaks recovery when local files are missing or metadata.files is stale while still at the same tip. Remove the early return and add a regression test for missing blobs at unchanged commit. Co-authored-by: Danny Peck <dannypeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes an incorrect early return in
refreshViaGitHubApithat skipped file reconciliation whenever the remote branch tip matched the storedcommitSha.Problem
commitShaequality does not imply the working copy matches the remote tree. After a crash, partial download, manual deletion, or stalemetadata.files, the user could stay on the correct commit while missing files. Refresh then did nothing, leaving notes invisible or corrupt relative to GitHub.Change
refreshViaGitHubApi.Validation
npx jest mobile/__tests__/services/gitService.test.ts