feature-intern-ResolveDependencyConflictsNew to main#10343
Merged
sachin-sandhu merged 3 commits intomainfrom Aug 13, 2024
Merged
feature-intern-ResolveDependencyConflictsNew to main#10343sachin-sandhu merged 3 commits intomainfrom
sachin-sandhu merged 3 commits intomainfrom
Conversation
JamieMagee
reviewed
Aug 1, 2024
NadiamB
force-pushed
the
feature-intern-ResolveDependencyConflictsNew
branch
4 times, most recently
from
f689e8f to
437c713
Compare
jpinz
approved these changes
Aug 8, 2024
Contributor
jpinz
left a comment
jpinz
left a comment
There was a problem hiding this comment.
This is amazing to see!
I know your last day is tomorrow, so no pressure to resolve any of these comments, I just wanted to provide some feedback!
Thanks for all of your hard work this summer!
Contributor
There was a problem hiding this comment.
q: was this change meant to be checked in?
Contributor
There was a problem hiding this comment.
We added a smoke test, this was just to make sure it was green in CI. The commit that added this will be removed prior to merging.
Contributor
There was a problem hiding this comment.
We just revert back this change because we are getting error.
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
reviewed
Aug 8, 2024
brettfo
approved these changes
Aug 9, 2024
NadiamB
force-pushed
the
feature-intern-ResolveDependencyConflictsNew
branch
from
0a45eb8 to
cfee286
Compare
abdulapopoola
approved these changes
Aug 9, 2024
Contributor
There was a problem hiding this comment.
Nitpick: It's generally good to name regions so that people know what's inside if they're collapsed.
Contributor
Author
There was a problem hiding this comment.
Will do these in follow up PR
Contributor
There was a problem hiding this comment.
Do we need to preserve this modified dependency somewhere?
Contributor
There was a problem hiding this comment.
Nitpick: Generally private methods go under public methods so it's easier to find the "entry-points".
sachin-sandhu
force-pushed
the
feature-intern-ResolveDependencyConflictsNew
branch
from
f411b68 to
144fc23
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My code is currently behind an environment variable not yet set. Will work with @brettfo to put this behind the experiment flag.
Looking for feedback on implementation, unit tests, variable names, etc.
DependencyConflictResolver.cs is the main code.
MSBuildHelper.cs and MSBuildHelperTests.cs were used for tests
UpdateWorkerTests.Sdk.cs was lightly used with testing with Brett
Added temporary commit to make smoke tests pass.
Smoke Test PR:
dependabot/smoke-tests#219
This is the PR that adds the experiment:
https://github.com/github/dependabot-api/pull/5511