Merged
Conversation
brettfo
force-pushed
the
dev/brettfo/docker-yaml-bom
branch
3 times, most recently
from
efe1b18 to
4494832
Compare
brettfo
force-pushed
the
dev/brettfo/docker-yaml-bom
branch
from
4494832 to
da97ce2
Compare
ryanbrandenburg
approved these changes
Mar 10, 2025
sachin-sandhu
force-pushed
the
dev/brettfo/docker-yaml-bom
branch
from
da97ce2 to
3f6e44e
Compare
sachin-sandhu
approved these changes
Mar 11, 2025
Contributor
sachin-sandhu
left a comment
sachin-sandhu
left a comment
There was a problem hiding this comment.
approving based on comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #11073 previously threw an error when a helm yaml file started with a byte-order-mark. It turns out it's trivial to remove this and allow the updates to continue.
Due to differences in how the unit tests fetch individual files, this new functionality has to be implemented as a smoke test; see PR dependabot/smoke-tests#282. That will be merged separately from this PR.