Skip to content

Revert "docker: consider the tag when checking if a digest is up-to-date"#13840

Merged
kbukum1 merged 1 commit intomainfrom
revert-13794-fix/consider-tag
Dec 19, 2025
Merged

Revert "docker: consider the tag when checking if a digest is up-to-date"#13840
kbukum1 merged 1 commit intomainfrom
revert-13794-fix/consider-tag

Conversation

@kbukum1
Copy link
Copy Markdown
Contributor

@kbukum1 kbukum1 commented Dec 19, 2025

Reverts #13794

Since merging #13794, Docker updates have started failing with update_not_possible, causing Dependabot to close PRs when updates should have been possible.

Based on initial investigation, this may be related to missing safeguarding in the digest comparison logic—specifically, handling cases when the expected digest cannot be determined (for example, due to transient registry errors):

# If we can't determine the expected digest (e.g., due to transient registry errors),
# we can't prove the digest is out of date, so conservatively assume it's up to date.
# This prevents false positives where we incorrectly mark dependencies as needing updates.
next true if expected_digest.nil?

@kbukum1 kbukum1 requested a review from a team as a code owner December 19, 2025 21:03
@github-actions github-actions bot added the L: docker Docker containers label Dec 19, 2025
@kbukum1 kbukum1 enabled auto-merge (squash) December 19, 2025 21:11
@kbukum1 kbukum1 disabled auto-merge December 19, 2025 21:12
@yeikel
Copy link
Copy Markdown
Contributor

yeikel commented Dec 19, 2025

I can confirm that reverting fixes the issue

updater | 2025/12/19 21:25:29 INFO Results:
updater | +------------------------------------------------------------------------------------------------------------------------------+
updater | | Changes to Dependabot Pull Requests |
updater | +---------+--------------------------------------------------------------------------------------------------------------------+
updater | | created | github/dependabot-update-job-proxy/dependabot-update-job-proxy ( from v2.0.20251124194534 to v2.0.20251219172147 ) |
updater | +---------+--------------------------------------------------------------------------------------------------------------------+
proxy | 2025/12/19 21:25:29 Skipping sending metrics because api endpoint is empty
proxy | 2025/12/19 21:25:29 9/35 calls cached (25%)

@kbukum1 kbukum1 merged commit c85499d into main Dec 19, 2025
83 checks passed
@kbukum1 kbukum1 deleted the revert-13794-fix/consider-tag branch December 19, 2025 21:40
@yeikel
Copy link
Copy Markdown
Contributor

yeikel commented Dec 23, 2025

I sent #13842 as a follow up for this

@kbukum1 Please take a look whenever you get a chance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L: docker Docker containers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants