Skip to content

Combine base path with request path#14058

Merged
JamieMagee merged 2 commits intomainfrom
jamiemagee/excon-combine-path
Jan 30, 2026
Merged

Combine base path with request path#14058
JamieMagee merged 2 commits intomainfrom
jamiemagee/excon-combine-path

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

@JamieMagee JamieMagee commented Jan 30, 2026

What are you trying to accomplish?

As a follow-up from #13800, this combines the path from base_url with the specific path for the http client request.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@JamieMagee JamieMagee requested a review from a team as a code owner January 30, 2026 18:34
ByAgenT
ByAgenT previously approved these changes Jan 30, 2026
@JamieMagee JamieMagee merged commit 4df0001 into main Jan 30, 2026
234 of 242 checks passed
@JamieMagee JamieMagee deleted the jamiemagee/excon-combine-path branch January 30, 2026 19:02
@yeikel
Copy link
Copy Markdown
Contributor

yeikel commented Jan 31, 2026

Thank you for this fix, I was not aware of this scenario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants