Add smoke test for npm maintainer encoding (PR #14638)#455
Open
v-HaripriyaC wants to merge 3 commits intomainfrom
Open
Add smoke test for npm maintainer encoding (PR #14638)#455v-HaripriyaC wants to merge 3 commits intomainfrom
v-HaripriyaC wants to merge 3 commits intomainfrom
Conversation
317c2ba to
bf92650
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Add smoke test coverage for dependabot-core#14638, which fixes broken Markdown links in the Maintainer changes section of Dependabot PR bodies when an npm releaser name contains spaces or other URL-unsafe characters (e.g.,
"GitHub Actions"). Addresses dependabot-core#14595.The test validates end-to-end that:
npm_and_yarncan analyse a package with a space-containing npm maintainer name.https://www.npmjs.com/~GitHub%20Actions) rather than the broken unencoded form.Anything you want to highlight for special attention from reviewers?
npm-package-json-lint@9.0.0is used specifically because the npm registry fixture in dependabot-core#14638 records version10.0.0as being published by"GitHub Actions"(with a space), making it the minimal reproducible case.npm/maintainer-spaces/package.jsonandpackage-lock.jsonpin the dependency to9.0.0so Dependabot proposes the9.0.0 → 10.0.0update and reaches the maintainer encoding path.tests/smoke-npm-maintainer-spaces.yaml) will need to be regenerated with the final merged commit SHA from dependabot-core#14638 before this PR is ready to merge.job_repo_not_foundrecord because the commit SHA is a placeholder; this will be replaced with the real expected output after regeneration.How will you know you've accomplished your goal?
create_pull_requestevent whose PR body includeshttps://www.npmjs.com/~GitHub%20Actions(percent-encoded).Checklist