Skip to content

ENH: Change how _parabola handles endpoints in case they are outliers#71

Merged
derb12 merged 2 commits intoderb12:developmentfrom
physicien:development
Mar 21, 2026
Merged

ENH: Change how _parabola handles endpoints in case they are outliers#71
derb12 merged 2 commits intoderb12:developmentfrom
physicien:development

Conversation

@physicien
Copy link
Copy Markdown

Description

Adds a way, through the local MAD, to deal with endpoint outliers in _parabola when used in the context of the beads algorithm. The problem and solution were originally reported in #70.

Type of Pull Request

  • Bug Fix
  • New Feature
  • Miscellaneous Changes (refactor, code improvements, etc.)
  • Documentation or Example Programs

Pull Request Checklist

  • New code and/or documentation is valid for use with the BSD 3-clause license.
  • New code is fully documented with docstrings that follow Numpy style,
    if applicable.
  • New code follows PEP 8 standards as closely as possible, if applicable.
  • Added/updated tests and ensured they pass locally, if applicable.
  • Verified that documentation builds locally, if applicable.

@derb12
Copy link
Copy Markdown
Owner

derb12 commented Mar 20, 2026

Glad to see the PR. I'll add a few review comments addressing the nits I had with the original implementation. Once you address the review comments, I'll run the CI and merge.

If you want to add the new parameter description to the docstrings or add tests looking for when outliers should and should not be detected, that would be good, but I can also do that after merging. BTW, thanks for using the commit prefix "ENH", that makes it easier for me to include this change when compiling the changelog; I should add that to the contribution guide...

Comment thread pybaselines/misc.py Outdated
Comment thread pybaselines/misc.py Outdated
Comment thread pybaselines/misc.py Outdated
Comment thread pybaselines/misc.py Outdated
Comment thread pybaselines/misc.py Outdated
Comment thread pybaselines/misc.py Outdated
@derb12
Copy link
Copy Markdown
Owner

derb12 commented Mar 21, 2026

CI's all green, so this is good to go. Thanks a lot @physicien for the contribution!

I wanted to also mention that I will be submitting an article on pybaselines to the journal of open source software (JOSS) someday (hopefully within the next year), so I would like to include an acknowledgement to you since you contributed to this package. If you prefer I don't, just let me know; absolutely fine either way.

@derb12 derb12 merged commit 14bd82b into derb12:development Mar 21, 2026
11 checks passed
@physicien
Copy link
Copy Markdown
Author

Cool, off course you can include me in the acknowledgement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants