ENH: Change how _parabola handles endpoints in case they are outliers#71
ENH: Change how _parabola handles endpoints in case they are outliers#71derb12 merged 2 commits intoderb12:developmentfrom
Conversation
|
Glad to see the PR. I'll add a few review comments addressing the nits I had with the original implementation. Once you address the review comments, I'll run the CI and merge. If you want to add the new parameter description to the docstrings or add tests looking for when outliers should and should not be detected, that would be good, but I can also do that after merging. BTW, thanks for using the commit prefix "ENH", that makes it easier for me to include this change when compiling the changelog; I should add that to the contribution guide... |
…cstrings for parabola_len
|
CI's all green, so this is good to go. Thanks a lot @physicien for the contribution! I wanted to also mention that I will be submitting an article on pybaselines to the journal of open source software (JOSS) someday (hopefully within the next year), so I would like to include an acknowledgement to you since you contributed to this package. If you prefer I don't, just let me know; absolutely fine either way. |
|
Cool, off course you can include me in the acknowledgement. |
Description
Adds a way, through the local MAD, to deal with endpoint outliers in
_parabolawhen used in the context of thebeadsalgorithm. The problem and solution were originally reported in #70.Type of Pull Request
Pull Request Checklist
if applicable.