Conversation
dereklee0310
requested changes
Feb 17, 2026
Owner
dereklee0310
left a comment
There was a problem hiding this comment.
Hi, thanks for the pr, there are a few things that need to be changed.
Owner
|
lgtm, could you please do a final check to ensure that everything is working as expected? |
Contributor
Author
Yes, I checked everything and corrected the formatting error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i18n
Uses
python-i18n[YAML]for user-facing strings (print, panels, tables, argparse help).Logger messages are not translated.
YAML was chosen because the project already depends on
pyyaml— no extra dependencies for the format itself.Files
en.yml/ru.yml/zh-TW.yml— one flat file per language, +-143 keys each__init__.py— exposessetup(language)andt(key, **kwargs)Usage
Language is set from
cfg.LANGUAGE(en/ru/zh-TW) inmain.pyviasetup_i18n(cfg.LANGUAGE).Fallback is always
en.i18n (ru)
Используется
python-i18n[YAML]для пользовательского вывода (print, панели, таблицы, argparse help).Сообщения логгера не переводятся.
YAML выбран потому что проект уже зависит от
pyyaml— формат не тянет лишних зависимостей.Файлы
en.yml/ru.yml/zh-TW.yml— один плоский файл на язык, +-143 ключа__init__.py— экспортируетsetup(language)иt(key, **kwargs)Использование
Язык берётся из
cfg.LANGUAGE(en/ru/zh-TW) вmain.pyчерезsetup_i18n(cfg.LANGUAGE).Fallback всегда
en.