Skip to content

Conversation

talaharoni
Copy link
Member

Related Issues

Description

Add the ability to create outbound application according to existing dcr preset

Must

  • Tests
  • Documentation (if applicable)

@Copilot Copilot AI review requested due to automatic review settings September 3, 2025 16:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to create outbound applications using DCR (Dynamic Client Registration) presets, providing an alternative creation method to the existing manual application creation.

  • Adds a new method create_application_by_dcr_preset to the outbound application management
  • Introduces a new API endpoint path for DCR preset-based application creation
  • Includes comprehensive test coverage for both success and failure scenarios

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
descope/management/outbound_application.py Implements the new create_application_by_dcr_preset method with proper documentation
descope/management/common.py Adds the API endpoint path for DCR preset application creation
tests/management/test_outbound_application.py Adds unit tests for both success and failure cases of the new functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@talaharoni talaharoni requested a review from gaokevin1 September 3, 2025 16:35
Copy link

github-actions bot commented Sep 3, 2025

Coverage report

The coverage rate went from 97.79% to 97.79% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/management/outbound_application.py

100% of new lines are covered (100% of the complete file).

descope/management/common.py

100% of new lines are covered (99.57% of the complete file).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant