allow additional characters in TLDs for CNAME records#1182
Closed
mdonoughe wants to merge 1 commit intodesec-io:mainfrom
Closed
allow additional characters in TLDs for CNAME records#1182mdonoughe wants to merge 1 commit intodesec-io:mainfrom
mdonoughe wants to merge 1 commit intodesec-io:mainfrom
Conversation
peterthomassen
requested changes
Jan 22, 2026
peterthomassen
force-pushed
the
punycode-cname
branch
from
fb4aaba to
9254eee
Compare
Member
|
done via #1195 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't really understand what this regex is supposed to be accomplishing. Apparently, the intention is that the validation is only supposed to allow domains that are both syntactically valid and have a valid ICANN TLD, but the TLD validation is not compatible with punycode TLDs because they have hyphens. This could probably be done better. I just copied the character class from the repeating part to the terminal part.
There doesn't need to be a backend change for this. I've been using punycode TLDs with CNAMEs through the API and by using
$0.click()in the browser developer tools.