Enable use of proxy when downloading Git binary#539
Open
itsananderson wants to merge 4 commits intodesktop:mainfrom
Open
Enable use of proxy when downloading Git binary#539itsananderson wants to merge 4 commits intodesktop:mainfrom
itsananderson wants to merge 4 commits intodesktop:mainfrom
Conversation
|
it work |
|
Why is not still merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this project switched away from
requests, support for configuring a proxy via theHTTP_PROXY/HTTPS_PROXYenvironment variables was lost. This change restores proxy support by adding theglobal-agentpackage as a dependency and setting it up in the download script before attempting to download Git.By default,
global-agentonly looks for environment variables prefixed byGLOBAL_AGENT_(e.g.GLOBAL_AGENT_HTTP_PROXY). To maintain backward compatibility, the download script checks for the oldHTTP_PROXY/HTTPS_PROXYvariables, and copies them to theGLOBAL_AGENT_equivalent if not already defined.Fixes #498