Skip build on platforms other than Windows#196
Open
vweevers wants to merge 1 commit intodesktop:masterfrom
Open
Skip build on platforms other than Windows#196vweevers wants to merge 1 commit intodesktop:masterfrom
vweevers wants to merge 1 commit intodesktop:masterfrom
Conversation
Necessary when dependents are cross-platform. The alternatives are setting "os" in package.json (which only works for yarn, not npm), using optionalDependencies in dependents (which would unfortunately ignore legit build failures), or building a dummy native addon (which is the current approach but it requires users to have an otherwise unnecessary build toolchain). This simple solution works for both yarn and npm. Also accounts for cross-compiling scenarios (when process.platform does not match the target platform) by checking env.npm_config_platform.
|
@sergiou87 This solution looks sleek, though I didn't verify. Would you consider to approve it for a rc build? |
toebeann
reviewed
Aug 9, 2024
| @@ -0,0 +1,5 @@ | |||
| const platform = process.env.npm_config_platform || process.platform | |||
|
|
|||
| if (platform === 'win32') { | |||
There was a problem hiding this comment.
Shouldn't this if condition be negated, so that it only exits with code 1 when the platform is not win32?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary when dependents are cross-platform. The alternatives are setting "os" in
package.json(which only works for yarn,not npm), using
optionalDependenciesin dependents (which would unfortunately ignore legit build failures), or building a dummy native addon (which is the current approach but it requires users to have an otherwise unnecessary build toolchain).This simple solution works for both yarn and npm. Also accounts for cross-compiling scenarios (when
process.platformdoes not match the target platform) by checkingenv.npm_config_platform.