Skip to content

Add permissions to build job in CI workflow#289

Merged
niik merged 3 commits intomasterfrom
copilot/update-lint-job-permissions
Nov 24, 2025
Merged

Add permissions to build job in CI workflow#289
niik merged 3 commits intomasterfrom
copilot/update-lint-job-permissions

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

The build job in .github/workflows/ci.yml did not set explicit permissions. This adds contents: read to follow the principle of least privilege.

Changes

  • Added permissions: contents: read to the existing build job
jobs:
  build:
    name: Build
    runs-on: windows-2022
    permissions:
      contents: read
    strategy:
      fail-fast: false
      # ...

This change follows GitHub Actions security best practices by explicitly setting permissions and following the principle of least privilege.

Original prompt

This section details on the original issue you should resolve

<issue_title>Add permissions to the lint job</issue_title>
<issue_description>The lint job in .github/workflows/ci.yml does not set explicit permissions. Update it to set contents: read only.</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: niik <634063+niik@users.noreply.github.com>
Copilot AI changed the title [WIP] Add permissions to the lint job Add permissions to lint job in CI workflow Nov 24, 2025
Copilot AI requested a review from niik November 24, 2025 09:07
Copy link
Member

@niik niik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I copy pasted instructions from another repository. I meant that the build job didn't have explicit permissions. There's no need to create a new job, revert the changes you did and just set the permissions on the existing build job.

Co-authored-by: niik <634063+niik@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Nov 24, 2025

Sorry, I copy pasted instructions from another repository. I meant that the build job didn't have explicit permissions. There's no need to create a new job, revert the changes you did and just set t...

Reverted the changes and added permissions: contents: read to the existing build job instead. (690c878)

Copilot AI changed the title Add permissions to lint job in CI workflow Add permissions to build job in CI workflow Nov 24, 2025
Copilot AI requested a review from niik November 24, 2025 09:17
@niik niik marked this pull request as ready for review November 24, 2025 09:26
@niik niik merged commit 2e57a76 into master Nov 24, 2025
4 checks passed
@niik niik deleted the copilot/update-lint-job-permissions branch November 24, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add permissions to the lint job

2 participants