Conversation
| // `mathquillify` calls `createTextarea` | ||
| super.mathquillify('mq-math-mode'); | ||
| if (this.__options.enableDigitGrouping) { | ||
| this.__controller.root.domFrag().addClass('mq-show-grouping'); |
There was a problem hiding this comment.
this is the key win here: static math immediately shows digit grouping, and editing around it doesn't impact it
| .mq-ellipsis-end { | ||
| margin-left: @ellipsis-internal-sep; | ||
| margin-right: @ellipsis-separator; | ||
| } |
There was a problem hiding this comment.
I'm struggling to see exactly what this file looked like before and what it looks like after. It seems like maybe .mq-ellipsses-* classes are now inside of .mq-show-grouping. And maybe they were global before and not changed by .mq-suppress-grouping. Does this mean that we are changing when those show up? Do we delay the ellipsis styling and is that intentional?
UPDATE - It does look like this is a change. I'm not positive it feels good to me. I prefer the ... padding immediately and not on delay. How do you feel about it? It changing later is a little jarring. The digit spacing is less jarring because we try to not update the width of the content. But the ... does change the width of the content.
There was a problem hiding this comment.
shoot, great catch. I agree -- those should be immediate
2 participants
Situation: when you have an "ans" inside of an editable math in the scientific calculator, the digits inside of the ans switch into and out of digit grouping as you type, which is surprising and disconcerting.
Change of design is to have a timeout for editable math to make digit grouping visible, and to always have that turned on for a static math, so now a static math inside of an editable math will always permanent digit grouping.