Skip to content

Adds details about X.com posts when hovering over an X link. #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sad4whattt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds details about X.com posts when hovering over an X link. #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 85 additions & 36 deletions assets/chat/js/chat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,19 @@ import { isMuteActive, MutedTimer } from './mutedtimer';
import EmoteService from './emotes';
import UserFeatures from './features';
import UserRoles from './roles';
import { UserMessageService, YouTubeOEmbedService } from './services';
import {
UserMessageService,
YouTubeOEmbedService,
XComOEmbedService,
} from './services';
import makeSafeForRegex, {
regextime,
nickmessageregex,
nickregex,
nsfwregex,
nsflregex,
youtubeidregex,
xcomregex,
} from './regex';
import { HashLinkConverter, MISSING_ARG_ERROR } from './hashlinkconverter';
import ChatCommands, { getSlashCommand, removeSlashCommand } from './commands';
Expand Down Expand Up @@ -95,6 +100,7 @@ class Chat {
this.emoteService = new EmoteService();
this.userMessageService = new UserMessageService();
this.youtubeOEmbedService = new YouTubeOEmbedService();
this.xComOEmbedService = new XComOEmbedService();

this.user = new ChatUser();
this.users = new Map();
Expand Down Expand Up @@ -448,7 +454,7 @@ class Chat {
this.focusIfNothingSelected();
});

// Youtube oEmbed tooltip
// Youtube oEmbed tooltip and X.com post tooltip
this.ui.on('mouseover', 'a.externallink', async (e) => {
const { target } = e;

Expand All @@ -462,50 +468,93 @@ class Chat {
return;
}

const match = target.href.match(youtubeidregex);

// Not a youtube id
if (!match) {
return;
}
// Check for YouTube URLs
const youtubeMatch = target.href.match(youtubeidregex);
if (youtubeMatch) {
try {
const result = await this.youtubeOEmbedService.getOEmbed(
youtubeMatch[1],
);

try {
const result = await this.youtubeOEmbedService.getOEmbed(match[1]);
const container = document.createElement('div');
container.style.display = 'flex';
container.style.flexDirection = 'column';
container.style.marginTop = '4px';
container.style.gap = '0.25em';

const container = document.createElement('div');
container.style.display = 'flex';
container.style.flexDirection = 'column';
container.style.marginTop = '4px';
container.style.gap = '0.25em';
const img = document.createElement('img');
img.src = result.thumbnail_url;

const img = document.createElement('img');
img.src = result.thumbnail_url;
const title = document.createElement('strong');
title.textContent = result.title;

const title = document.createElement('strong');
title.textContent = result.title;
const author = document.createElement('span');
author.textContent = result.author_name;

const author = document.createElement('span');
author.textContent = result.author_name;
container.append(img, title, author);

container.append(img, title, author);
const youtubeTippy = tippy(target, {
content: container,
allowHTML: true,
arrow: roundArrow,
duration: 0,
theme: 'dgg',
maxWidth: 250,
});

const youtubeTippy = tippy(target, {
content: container,
allowHTML: true,
arrow: roundArrow,
duration: 0,
theme: 'dgg',
maxWidth: 250,
});
target.dataset.tipped = true;

target.dataset.tipped = true;
// If still hovering show immediately.
if (target.matches(':hover')) {
youtubeTippy.show();
}
} catch (error) {
/* Do nothing */
}
return;
}

// If still hovering show immediately.
if (target.matches(':hover')) {
youtubeTippy.show();
// Check for X.com URLs
const xcomMatch = target.href.match(xcomregex);
if (xcomMatch) {
try {
const result = await this.xComOEmbedService.getOEmbed(xcomMatch[1]);

const container = document.createElement('div');
Copy link
Contributor

@11k 11k Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you extract some of the common logic for building a container div and instantiating the tooltip instance to a separate function?

container.style.display = 'flex';
container.style.flexDirection = 'column';
container.style.marginTop = '4px';
container.style.gap = '0.25em';
container.style.padding = '8px';

const author = document.createElement('strong');
author.textContent = result.author_name;
author.style.color = '#ffffff';

const title = document.createElement('div');
title.innerHTML = result.html;
title.style.marginTop = '4px';

container.append(author, title);

const xcomTippy = tippy(target, {
content: container,
allowHTML: true,
arrow: roundArrow,
duration: 0,
theme: 'dgg',
maxWidth: 250,
});

target.dataset.tipped = true;

// If still hovering show immediately.
if (target.matches(':hover')) {
xcomTippy.show();
}
} catch (error) {
/* Do nothing */
}
} catch (error) {
/* Do nothing */
}
});

Expand Down
Loading