Skip to content

Fix: Update useQualitySelector Hook to Persist User-Selected Quality#17

Closed
TuringQuantrix wants to merge 1 commit intodestinygg:mainfrom
TuringQuantrix:fix/16/quality-persistence-on-play-pause-reload
Closed

Fix: Update useQualitySelector Hook to Persist User-Selected Quality#17
TuringQuantrix wants to merge 1 commit intodestinygg:mainfrom
TuringQuantrix:fix/16/quality-persistence-on-play-pause-reload

Conversation

@TuringQuantrix
Copy link
Contributor

@TuringQuantrix TuringQuantrix commented Feb 3, 2026

  • Added logic to make sure when the stream emits events we re-apply the user-selected quality if it reset to auto
  • Added refs to avoid stale closures and to ensure consistent re-apply behavior across player events (part of above logic)
  • Extracted the quality re-apply debounce timeout

Why This Happens:
IVS resets to auto quality when transitioning from Idle to Playing (reload or play/pause). I missed this detail in my first pass (I assumed it was due to my previous PR because it was recently merged but it looks like this is a bug pre nested menu as well). When the user would perform any of these actions the stream would reset to auto quality but the menu would reference the old value.

How I Tested:

  • Set quality to 160p -> reload page -> confirm quality sticks
  • Set quality to 160p -> pause then play stream -> confirm quality sticks
  • Set quality to 1080p -> reload page -> confirm quality sticks
  • Set quality to 1080p -> reload page -> confirm quality sticks
  • Set quality to 160p -> pause stream -> change quality to 1080p -> play stream -> confirm new quality (1080p) sticks

All of the above were confirmed with logging on every stream event to confirm the quality coming in

…er-selected quality when IVS resets it to auto
@TuringQuantrix TuringQuantrix marked this pull request as draft February 3, 2026 03:42
@TuringQuantrix TuringQuantrix marked this pull request as ready for review February 3, 2026 03:43
@11k 11k closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants