Fix: Update useQualitySelector Hook to Persist User-Selected Quality#17
Closed
TuringQuantrix wants to merge 1 commit intodestinygg:mainfrom
Closed
Conversation
…er-selected quality when IVS resets it to auto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why This Happens:
IVS resets to auto quality when transitioning from Idle to Playing (reload or play/pause).
I missed this detail in my first pass(I assumed it was due to my previous PR because it was recently merged but it looks like this is a bug pre nested menu as well). When the user would perform any of these actions the stream would reset to auto quality but the menu would reference the old value.How I Tested:
All of the above were confirmed with logging on every stream event to confirm the quality coming in