fix: Resolve SAFETY BLOCK for files in library root (#201)

[deucebucket]

Summary

• Fixed path normalization mismatch where Windows mapped drives (e.g. R:\) resolve to UNC paths (\\server\share) but config paths were compared without .resolve(), causing library matching to fail
• Fixed fallback logic that assumed 2-level directory structure (parent.parent), which went above the library root for loose files sitting directly in a library
• Applied consistent fix across all 4 locations in 3 files: layer_ai_queue.py, layer_audio_credits.py, and app.py

Test plan

• Configure a library path using a Windows mapped drive
• Place audio files directly in the library root (not in subfolders)
• Run a Deep Library Scan
• Apply a pending fix and verify no SAFETY BLOCK error
• Verify normal subfolder books still process correctly

Closes #201

[bucket-agent]

🔍 Vibe Check Review

Context

Fixes SAFETY BLOCK error when processing audiobook files placed directly in a library root directory on Windows, where mapped drives resolve to UNC paths causing relative_to() mismatches.

Codebase Patterns I Verified

• Library matching pattern: 4 locations in app.py, layer_ai_queue.py, layer_audio_credits.py iterate library_paths with relative_to() — all 4 are fixed in this PR
• Fifth location missed: library_manager/pipeline/layer_content.py:116-125 has the identical unfixed pattern — no .resolve(), and uses parent.parent fallback
• build_new_path() in path_safety.py:688-694 already resolves both result_path and lib_path internally, so passing a pre-resolved lib_path from the fix is safe
• is_file() fallback logic is correct: loose files in library root need .parent (1 level), directories need .parent.parent (2 levels)

✅ Good

• Fix is correct and well-targeted — .resolve() on both sides of relative_to() is exactly right for the Windows mapped drive → UNC path mismatch
• The is_file() guard for the fallback is a clean way to handle loose files vs Author/Title directories
• Applied consistently across all 4 changed locations
• CHANGELOG entry is thorough and explains the root cause clearly
• Version bump is consistent across app.py, README.md, and CHANGELOG.md

🚨 Issues Found

Severity	Location	Exact Code Quote	Issue	Fix
HIGH	layer_content.py:118	book_path.relative_to(Path(lp))	Same unresolved relative_to() bug exists here — no .resolve() on either side. Will trigger the same SAFETY BLOCK on Windows mapped drives.	Add .resolve() to both book_path and Path(lp) matching the pattern in the other 4 locations
HIGH	layer_content.py:125	lib_path = book_path.parent.parent	Same parent.parent fallback bug for loose files exists here — unfixed.	Add the same is_file() guard: if book_path.is_file(): lib_path = book_path.parent else: lib_path = book_path.parent.parent

📋 Scope Verification

Issue	Problem	Addressed?	Notes
#201	SAFETY BLOCK error for files in library root on Windows mapped drives	⚠️	Fixed in 4 of 5 locations — layer_content.py has the identical bug unfixed

Scope Status: SCOPE_PARTIAL

📝 Documentation Check

• CHANGELOG.md: ✅ Updated — thorough entry explaining root cause
• README.md: ✅ Version badge updated

🎯 Verdict

REQUEST_CHANGES

The fix is correct everywhere it's applied, but library_manager/pipeline/layer_content.py:116-125 has the exact same bug (unresolved relative_to() + parent.parent fallback) and was not included. Apply the same two changes there to complete the fix across all code paths.

[bucket-agent]

🔍 Vibe Check Review

Context

Fixes SAFETY BLOCK errors when processing loose audio files sitting directly in a library root (e.g. R:\book.mp3) by adding .resolve() to path comparisons (fixing Windows mapped drive vs UNC mismatch) and replacing blind parent.parent fallback with an is_file() check.

Codebase Patterns I Verified

• Path resolution: build_new_path() in path_safety.py:690-691 already resolves both result_path and lib_path for its safety check — the PR's caller-side .resolve() is consistent with this
• Library path matching: The for lp in config.get('library_paths', []) + relative_to() pattern is used in 5 locations; PR fixes all of them
• Watch folder handling: layer_ai_queue.py:467-468 already uses .resolve() for watch folder matching — the PR brings library path matching to the same standard
• Fallback pattern: All 5 locations had the same parent.parent fallback; all 5 are updated consistently

✅ Good

• Fix applied consistently across all 5 locations where the pattern exists (app.py x2, layer_ai_queue.py, layer_audio_credits.py, layer_content.py)
• The is_file() fallback logic is correct: loose files in root need .parent (one level), directories in Author/Title structure need .parent.parent (two levels)
• Non-existent paths fall through to parent.parent (same as before), so no regression for edge cases
• CHANGELOG entry is thorough and explains the root cause clearly
• Version bump consistent across app.py, README.md, and CHANGELOG.md

🚨 Issues Found

No issues found.

📋 Scope Verification

Issue	Problem	Addressed?	Notes
#201	SAFETY BLOCK error for files in library root on Windows (mapped drive → UNC mismatch + parent.parent going above root)	✅	Both root causes fixed: .resolve() for path comparison and is_file() guard for fallback

Scope Status: SCOPE_OK

📝 Documentation Check

• CHANGELOG.md: ✅ Updated with detailed explanation
• README.md: ✅ Version badge updated

🎯 Verdict

APPROVE — Clean, focused bug fix. Both root causes identified in #201 are addressed consistently across all affected code paths.

---

_{🤖 Ruthless review by vibe-check}