Skip to content

Conversation

hyu-dev
Copy link
Contributor

@hyu-dev hyu-dev commented Oct 5, 2025

landing docs api 문서 정리해봤습니다.

기존 before, after 만 구성되어 있던 부분에서
컴포넌트 사용 방법과 해당 컴포넌트가 어떻게 변환되는지 2단계로 분리하여 작성했습니다.

내용이 변한 건 없고, 간단하게 살만 좀 더 붙여서 작성해봤습니다.
빈 문서 또는 내용이 빈약한 항목에 대해 빠르게 작업하고, 추후 살을 더 붙이는 방식으로 진행하는 것이 좋을 것 같아
간단하게 정리하여 먼저 올려봅니다.

Copy link

changeset-bot bot commented Oct 5, 2025

⚠️ No Changeset found

Latest commit: 692f8c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +48 to +49
If you pass a number without a unit to a style property, it will be automatically scaled by 4.
This means 1 equals 4px, 2 equals 8px, and so on.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가적으로 명시해야할 것이 생각나서 작성합니다.
아래의 항목들은 예외적으로 곱하기 4 가 되지 않습니다

pub(super) static MAINTAIN_VALUE_PROPERTIES: phf::Set<&str> = phf_set! {
    "opacity",
    "flex",
    "z-index",
    "line-clamp",
    "font-weight",
    "line-height",
    "scale",
    "aspect-ratio",
    "flex-grow",
    "flex-shrink",
    "order",
    "grid-column",
    "grid-column-start",
    "grid-column-end",
    "grid-row",
    "grid-row-start",
    "grid-row-end",
    "animation-iteration-count",
    "tab-size",
    "moz-tab-size",
    "-webkit-line-clamp"
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owjs3901 말씀하신 내용 추가해서 반영했습니다


```tsx
function App() {
return <div className="aa ab ac a-d" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기서는 이해를 돕기 위해 클래스명을 기본형으로 명시했으면 좋겠습니다.
가령 아래와 같습니다.
a b c d

Copy link
Contributor Author

@hyu-dev hyu-dev Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owjs3901 올린 문서 모두 클래스명을 a, b, c, d 형태로 표현하면 될까요?

일단 모두 a,b,c 형태로 수정했습니다.

const after = <span className="d0" />
```tsx
function App() {
return <span className="aa" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

기본형인 a로 표시하는 것을 권장합니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants