-
-
Notifications
You must be signed in to change notification settings - Fork 20
Issue #394 Rewrite landing docs api #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
If you pass a number without a unit to a style property, it will be automatically scaled by 4. | ||
This means 1 equals 4px, 2 equals 8px, and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
추가적으로 명시해야할 것이 생각나서 작성합니다.
아래의 항목들은 예외적으로 곱하기 4 가 되지 않습니다
pub(super) static MAINTAIN_VALUE_PROPERTIES: phf::Set<&str> = phf_set! {
"opacity",
"flex",
"z-index",
"line-clamp",
"font-weight",
"line-height",
"scale",
"aspect-ratio",
"flex-grow",
"flex-shrink",
"order",
"grid-column",
"grid-column-start",
"grid-column-end",
"grid-row",
"grid-row-start",
"grid-row-end",
"animation-iteration-count",
"tab-size",
"moz-tab-size",
"-webkit-line-clamp"
};
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owjs3901 말씀하신 내용 추가해서 반영했습니다
|
||
```tsx | ||
function App() { | ||
return <div className="aa ab ac a-d" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기서는 이해를 돕기 위해 클래스명을 기본형으로 명시했으면 좋겠습니다.
가령 아래와 같습니다.
a b c d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owjs3901 올린 문서 모두 클래스명을 a, b, c, d 형태로 표현하면 될까요?
일단 모두 a,b,c 형태로 수정했습니다.
const after = <span className="d0" /> | ||
```tsx | ||
function App() { | ||
return <span className="aa" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기본형인 a
로 표시하는 것을 권장합니다.
landing docs api 문서 정리해봤습니다.
기존 before, after 만 구성되어 있던 부분에서
컴포넌트 사용 방법과 해당 컴포넌트가 어떻게 변환되는지 2단계로 분리하여 작성했습니다.
내용이 변한 건 없고, 간단하게 살만 좀 더 붙여서 작성해봤습니다.
빈 문서 또는 내용이 빈약한 항목에 대해 빠르게 작업하고, 추후 살을 더 붙이는 방식으로 진행하는 것이 좋을 것 같아
간단하게 정리하여 먼저 올려봅니다.