Skip to content

Fix/UI video card sidebar async#70

Merged
devchaudhary24k merged 3 commits intodevfrom
fix/ui-video-card-sidebar-async
Apr 22, 2026
Merged

Fix/UI video card sidebar async#70
devchaudhary24k merged 3 commits intodevfrom
fix/ui-video-card-sidebar-async

Conversation

@devchaudhary24k
Copy link
Copy Markdown
Owner

@devchaudhary24k devchaudhary24k commented Apr 22, 2026

Summary

Related

Closes #

Type of change

  • feat — new capability
  • fix — bug fix
  • refactor — no behavior change
  • perf — performance improvement
  • docs / chore / ci / test / style / build / revert

Scope

  • apps/api
  • apps/app
  • workers/transcoder
  • packages/*
  • tooling/* / .github/ / .husky/ / .claude/

Checklist

  • Branch started from a fresh dev and is up to date with dev
  • pnpm check-types passes
  • pnpm lint passes with zero warnings
  • pnpm format clean
  • Relevant tests added / updated; pnpm test green
  • No any, no non-null assertions, no @ts-ignore without a comment
  • No process.env.* outside env.ts; no backend packages imported from apps/app
  • Errors logged with message + stack; no swallowed catches
  • No secrets, no .env file edited (except .env.example)
  • Response shapes use t.Pick / t.Omit — never raw createSelectSchema(table)

If schema changed

  • Ran pnpm run db:migrate -- --name="<snake_case>"
  • Generated migration staged in this commit
  • Migration is idempotent + reversible where possible

If UI changed

  • Tested in the browser (golden path + edge cases)
  • No new files under apps/app/src/components/ (feature code belongs in features/<name>/)
  • Did not edit packages/ui/src/components/** (vendored shadcn)

Screenshots / recordings

Migration / rollout notes

Notes for reviewers

VideoThumb was living inside features/videos but is about to be used
from features/folders too. Promote to apps/app/src/components so both
features share a single implementation.
Folder browse endpoint was returning bare video metadata, so folder
cards rendered a gradient placeholder. The video feed already joins
thumbnail + preview_gif assets and signs URLs — mirror that on the
folder service so the browse view matches.

- VideoSummary response gains thumbnailUrl + previewUrl
- listChildVideos switches to db.query with assets relation + signs URLs
- Folders video-card uses the shared VideoThumb for poster + hover preview
- Loading state swaps the "Loading…" placeholder for FolderGridSkeleton
@devchaudhary24k devchaudhary24k merged commit 97dc438 into dev Apr 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant