Skip to content

All issues fixed #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

All issues fixed #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
210a56c
Fix #4
japoodev Nov 18, 2022
1448210
Fix #1
japoodev Nov 18, 2022
fe9ed97
Fix #2 #3
japoodev Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const COMPANIES_API_PATH = "/companies";

export const COMPANIES_TABLE_HEADERS = ["Company Name", "Status", "Created At", "Revenue YTD", "Account Executive"];

export const COMPANY_NAME_FIELD_NAME = "company_name";
export const COMPANY_NAME_FIELD_NAME = "name";
export const STATUS_FIELD_NAME = "status";
export const CREATED_AT_FIELD_NAME = "created_at";
export const REVENUE_YTD_FIELD_NAME = "revenue_ytd";
Expand Down
4 changes: 2 additions & 2 deletions src/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ export const makeTable = async () => {
row.push(
company[COMPANY_NAME_FIELD_NAME],
company[STATUS_FIELD_NAME],
company[CREATED_AT_FIELD_NAME],
company[REVENUE_YTD_FIELD_NAME],
company[CREATED_AT_FIELD_NAME].substring(11,16),
company[REVENUE_YTD_FIELD_NAME].toString().replace(/\B(?=(\d{3})+(?!\d))/g, " "),
company[ACCOUNT_EXECUTIVE_FIELD_NAME]
);
companiesToDisplay.push(row);
Expand Down
3 changes: 2 additions & 1 deletion styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ table {
By default, when you set borders on table elements, they will look pretty ugly.
*/
border-collapse: collapse;
border: 3px solid purple;
border: 3px solid lightblue;
}

thead th:nth-child(1) {
Expand All @@ -42,4 +42,5 @@ th, td {
/* nth-child is a pretty neat thing to use and is widely applicable in real-life projects. Reader is highly encouraged to do more reading on this. */
tr:nth-child(1) {
font-weight: bold;
background-color: lightblue;
}